LayoutTests/editing/spelling/move-cursor-to-misspelled-word.html - Issue 23534071: Use shouldBecomeEqual in asynchronous spellchecking tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/editing/spelling/move-cursor-to-misspelled-word.html

Issue 23534071: Use shouldBecomeEqual in asynchronous spellchecking tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: Apply Tony's review and use asynchronous spellchecking in two tests Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/editing/spelling/grammar-paste-expected.txt ('k') | LayoutTests/editing/spelling/move-cursor-to-misspelled-word-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script src=../../fast/js/resources/js-test-pre.js language="javascript" type="t ext/javascript"></script>	3 <script src=../../fast/js/resources/js-test-pre.js language="javascript" type="t ext/javascript"></script>

4 <title>Testing moving cursor to a misspelled word</title>	4 <title>Testing moving cursor to a misspelled word</title>

5 </head>	5 </head>

6 <body>	6 <body>

7 <div id="src" contenteditable="true" spellcheck="true"></div><br/>	7 <div id="src" contenteditable="true" spellcheck="true"></div><br/>

8 <script language="javascript">	8 <script language="javascript">

9 description('Test if Chrome WebKit does not remove a misspelled marker when movi ng a cursor on a misspelled word.' +	9 description('Test if Chrome WebKit does not remove a misspelled marker when movi ng a cursor on a misspelled word.' +

10 'To test manually, type a misspelled word "zz " and type a left-arro w key to move the cursor on it.' +	10 'To test manually, type a misspelled word "zz " and type a left-arro w key to move the cursor on it.' +

11 'This test succeeds when "zz" is marked as misspelled.');	11 'This test succeeds when "zz" is marked as misspelled.');

12	12

	13 jsTestIsAsync = true;

	14

13 internals.settings.setAsynchronousSpellCheckingEnabled(true);	15 internals.settings.setAsynchronousSpellCheckingEnabled(true);

14 var node = document.getElementById('src');	16 var node = document.getElementById('src');

15 node.focus();	17 node.focus();

16 document.execCommand("InsertText", false, 'z');	18 document.execCommand("InsertText", false, 'z');

17 document.execCommand("InsertText", false, 'z');	19 document.execCommand("InsertText", false, 'z');

18 document.execCommand("InsertText", false, ' ');	20 document.execCommand("InsertText", false, ' ');

19 window.getSelection().modify('move', 'backward', 'character');	21 window.getSelection().modify('move', 'backward', 'character');

20 shouldBeTrue('internals.hasSpellingMarker(document, 0, 2)');	22 shouldBecomeEqual('internals.hasSpellingMarker(document, 0, 2)', 'true', finishJ STest);

21 </script>	23 </script>

22 <script src="../../fast/js/resources/js-test-post.js"></script>	24 <script src="../../fast/js/resources/js-test-post.js"></script>

23 </body>	25 </body>

24 </html>	26 </html>

OLD	NEW