Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23534067: bulk replace Isolate::Current in tests (Closed)

Created:
7 years, 3 months ago by dcarney
Modified:
7 years, 3 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

bulk replace Isolate::Current in tests R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=16817

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+403 lines, -402 lines) Patch
M test/cctest/test-accessors.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-alloc.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/test-api.cc View 25 chunks +29 lines, -29 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 19 chunks +19 lines, -19 lines 0 comments Download
M test/cctest/test-assembler-mips.cc View 16 chunks +16 lines, -16 lines 0 comments Download
M test/cctest/test-assembler-x64.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M test/cctest/test-ast.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-compiler.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/test-dataflow.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-date.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-debug.cc View 27 chunks +30 lines, -30 lines 0 comments Download
M test/cctest/test-decls.cc View 15 chunks +16 lines, -16 lines 0 comments Download
M test/cctest/test-deoptimization.cc View 24 chunks +24 lines, -24 lines 0 comments Download
M test/cctest/test-dictionary.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-disasm-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-disasm-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-disasm-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-func-name-inference.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-global-handles.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-global-object.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-hashing.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-heap.cc View 57 chunks +62 lines, -62 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-liveedit.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-log.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M test/cctest/test-log-stack-tracer.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/test-macro-assembler-x64.cc View 22 chunks +22 lines, -22 lines 0 comments Download
M test/cctest/test-mark-compact.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/test-object-observe.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 17 chunks +20 lines, -20 lines 0 comments Download
M test/cctest/test-profile-generator.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-random.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-regexp.cc View 29 chunks +35 lines, -35 lines 0 comments Download
M test/cctest/test-serialize.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M test/cctest/test-spaces.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-strings.cc View 16 chunks +16 lines, -16 lines 0 comments Download
M test/cctest/test-symbols.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-thread-termination.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-types.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M test/cctest/test-unique.cc View 13 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dcarney
7 years, 3 months ago (2013-09-19 09:15:25 UTC) #1
Sven Panne
LGTM (rubberstamped)
7 years, 3 months ago (2013-09-19 09:16:47 UTC) #2
dcarney
7 years, 3 months ago (2013-09-19 09:17:52 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r16817 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698