[modules] Support exporting a local variable under multiple export names.

[modules] Support exporting a local variable under multiple export names.

R=adamk@chromium.org
BUG=v8:1569
Committed: https://crrev.com/b2b434df4179c0474eb7a377e80ff1452b0cda4c
Cr-Commit-Position: refs/heads/master@{#39604}

[neis, 2016-09-21 17:44:49]

ptal

[neis, 2016-09-21 17:44:57]

The CQ bit was checked by neis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 17:45:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[adamk, 2016-09-21 17:45:45]

Description was changed from

==========
[modules] Support exporting a local variable under multiple export names.

R=adamk@chromium.org
BUG=
==========

to

==========
[modules] Support exporting a local variable under multiple export names.

R=adamk@chromium.org
BUG=v8:1569
==========

[commit-bot: I haz the power, 2016-09-21 17:50:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 17:50:52]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[adamk, 2016-09-21 17:52:15]

https://codereview.chromium.org/2353403003/diff/1/src/ast/modules.cc
File src/ast/modules.cc (right):

https://codereview.chromium.org/2353403003/diff/1/src/ast/modules.cc#newcode120
src/ast/modules.cc:120: data.reserve(2 *
static_cast<int>(regular_exports_.size()));
No need for static_cast here, let's just pretend size() is OK :)

https://codereview.chromium.org/2353403003/diff/1/src/ast/modules.cc#newcode122
src/ast/modules.cc:122: int i = 0;
I don't see this used

https://codereview.chromium.org/2353403003/diff/1/src/ast/modules.cc#newcode137
src/ast/modules.cc:137: int j = 0;
I think you could call this "i" instead.

[neis, 2016-09-21 17:59:56]

The CQ bit was checked by neis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 18:00:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[neis, 2016-09-21 18:00:08]

On 2016/09/21 17:52:15, adamk wrote:
> https://codereview.chromium.org/2353403003/diff/1/src/ast/modules.cc
> File src/ast/modules.cc (right):
> 
>
https://codereview.chromium.org/2353403003/diff/1/src/ast/modules.cc#newcode120
> src/ast/modules.cc:120: data.reserve(2 *
> static_cast<int>(regular_exports_.size()));
> No need for static_cast here, let's just pretend size() is OK :)
> 
>
https://codereview.chromium.org/2353403003/diff/1/src/ast/modules.cc#newcode122
> src/ast/modules.cc:122: int i = 0;
> I don't see this used
> 
>
https://codereview.chromium.org/2353403003/diff/1/src/ast/modules.cc#newcode137
> src/ast/modules.cc:137: int j = 0;
> I think you could call this "i" instead.

All done.

[adamk, 2016-09-21 18:00:49]

lgtm

[commit-bot: I haz the power, 2016-09-21 18:44:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 18:44:41]

Dry run: This issue passed the CQ dry run.

[neis, 2016-09-21 18:44:55]

The CQ bit was checked by neis@chromium.org

[commit-bot: I haz the power, 2016-09-21 18:45:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 18:47:44]

Description was changed from

==========
[modules] Support exporting a local variable under multiple export names.

R=adamk@chromium.org
BUG=v8:1569
==========

to

==========
[modules] Support exporting a local variable under multiple export names.

R=adamk@chromium.org
BUG=v8:1569
==========

[commit-bot: I haz the power, 2016-09-21 18:47:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-21 18:48:40]

Description was changed from

==========
[modules] Support exporting a local variable under multiple export names.

R=adamk@chromium.org
BUG=v8:1569
==========

to

==========
[modules] Support exporting a local variable under multiple export names.

R=adamk@chromium.org
BUG=v8:1569

Committed: https://crrev.com/b2b434df4179c0474eb7a377e80ff1452b0cda4c
Cr-Commit-Position: refs/heads/master@{#39604}
==========

[commit-bot: I haz the power, 2016-09-21 18:48:41]

Patchset 2 (id:??) landed as
https://crrev.com/b2b434df4179c0474eb7a377e80ff1452b0cda4c
Cr-Commit-Position: refs/heads/master@{#39604}