Revert 156791 "Auto-rebaseline for r156783"

Revert 156791 "Auto-rebaseline for r156783"

Reason for revert: r156783 was reverted

> Auto-rebaseline for r156783
> 
> http://src.chromium.org/viewvc/blink?view=revision&revision=156783
> 
> BUG=100703
> TBR=junov@chromium.org
> 
> Review URL: https://codereview.chromium.org/23602003

TBR=ojan@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156866

[Justin Novosad, 2013-08-28 18:49:12]

Committed patchset #1 manually as r156866.

[ojan, 2013-08-28 19:11:17]

Just doing this revert it not sufficient because the rebaseline bot will
just re-rebaseline it because of the NeedsRebaseline lines in
TestExpectations.


On Wed, Aug 28, 2013 at 11:49 AM, <junov@chromium.org> wrote:

> Committed patchset #1 manually as r156866.
>
>
https://codereview.chromium.**org/23534013/<https://codereview.chromium.org/2...
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[Justin Novosad, 2013-08-28 19:16:00]

D'oh! so I should have interrupted drover, reverted TestExpectations, then
commit manually?
But I think this will be OK though, unless the auto-rebaseline tool chokes
when tests marked with NeedsRebaseline actually don't need to be
re-baselined?


On Wed, Aug 28, 2013 at 3:10 PM, Ojan Vafai <ojan@chromium.org> wrote:

> Just doing this revert it not sufficient because the rebaseline bot will
> just re-rebaseline it because of the NeedsRebaseline lines in
> TestExpectations.
>
>
> On Wed, Aug 28, 2013 at 11:49 AM, <junov@chromium.org> wrote:
>
>> Committed patchset #1 manually as r156866.
>>
>>
https://codereview.chromium.**org/23534013/<https://codereview.chromium.org/2...
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[ojan, 2013-08-28 19:17:38]

Actually, you're right, the rebaseline bot should just remove these lines
since the tests should be passing.


On Wed, Aug 28, 2013 at 12:15 PM, Justin Novosad <junov@chromium.org> wrote:

> D'oh! so I should have interrupted drover, reverted TestExpectations, then
> commit manually?
> But I think this will be OK though, unless the auto-rebaseline tool chokes
> when tests marked with NeedsRebaseline actually don't need to be
> re-baselined?
>
>
> On Wed, Aug 28, 2013 at 3:10 PM, Ojan Vafai <ojan@chromium.org> wrote:
>
>> Just doing this revert it not sufficient because the rebaseline bot will
>> just re-rebaseline it because of the NeedsRebaseline lines in
>> TestExpectations.
>>
>>
>> On Wed, Aug 28, 2013 at 11:49 AM, <junov@chromium.org> wrote:
>>
>>> Committed patchset #1 manually as r156866.
>>>
>>>
https://codereview.chromium.**org/23534013/<https://codereview.chromium.org/2...
>>>
>>
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.