Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2353393004: Use a whitelist for depot_tools pylint instead (Closed)

Created:
4 years, 3 months ago by agable
Modified:
4 years, 2 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Skip cpplint.py, since it should be in third_party #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M PRESUBMIT.py View 2 chunks +16 lines, -18 lines 0 comments Download
M cpplint.py View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
agable
4 years, 3 months ago (2016-09-22 20:27:49 UTC) #1
M-A Ruel
lgtm
4 years, 3 months ago (2016-09-23 01:11:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353393004/1
4 years, 3 months ago (2016-09-23 01:43:22 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: Depot Tools Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/316d87cfccf3eb10)
4 years, 3 months ago (2016-09-23 01:49:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353393004/20001
4 years, 2 months ago (2016-09-26 16:32:28 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 16:35:46 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/f39c33382a0ddf...

Powered by Google App Engine
This is Rietveld 408576698