Aura: Focus() in ShowAndFocusNativeWindowAura

chrome/test/base/interactive_test_utils_aura.cc

Index: chrome/test/base/interactive_test_utils_aura.cc
diff --git a/chrome/test/base/interactive_test_utils_aura.cc b/chrome/test/base/interactive_test_utils_aura.cc
index 258fdb9bef3d33d3cef01d3b2d49d90733a3a05c..e13fb39e48142bc87813a2e070471bd347119af0 100644
--- a/chrome/test/base/interactive_test_utils_aura.cc
+++ b/chrome/test/base/interactive_test_utils_aura.cc
@@ -26,7 +26,10 @@ void HideNativeWindowAura(gfx::NativeWindow window) {
 
 bool ShowAndFocusNativeWindowAura(gfx::NativeWindow window) {
   window->Show();
-  return true;
+  if (!window->IsVisible())
+    return false;

[sky, 2016/09/23 16:27:56]

is this branch actually getting hit? If so, where?

[Tom (Use chromium acct), 2016/09/23 20:34:57]

No

[sky, 2016/09/26 01:48:17]

Then can it be removed?

[Tom (Use chromium acct), 2016/09/26 19:15:41]

Done.

+  window->Focus();
+  return window->HasFocus();

[Tom (Use chromium acct), 2016/09/23 20:34:57]

HasFocus() is returning false.  This is because in
FocusController::FocusAndActivateWindow (focus_controller.cc:190), the window is
active, but not focused, so we early-return without getting focus.

[sky, 2016/09/26 01:48:17]

That is not necessarily problematic. What is the test case that fails?

[Tom (Use chromium acct), 2016/09/26 19:15:41]

Lots of them.  The example I was using to test was
WebViewPointerLockInteractiveTest.PointerLock_PointerLockLostWithFocus

I just changed this to return true like it was before :P

 }
 
 }  // namespace ui_test_utils