Aura: Focus() in ShowAndFocusNativeWindowAura

Aura: Focus() in ShowAndFocusNativeWindowAura

R=sky@chromium.org

BUG=649484
Committed: https://crrev.com/79cad3c950be7bff3b166b2c350770aaeca051fb
Cr-Commit-Position: refs/heads/master@{#421004}

[Tom (Use chromium acct), 2016-09-22 23:12:07]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 23:12:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 23:30:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 23:30:50]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2016-09-23 16:27:56]

https://codereview.chromium.org/2353353005/diff/1/chrome/test/base/interactiv...
File chrome/test/base/interactive_test_utils_aura.cc (right):

https://codereview.chromium.org/2353353005/diff/1/chrome/test/base/interactiv...
chrome/test/base/interactive_test_utils_aura.cc:30: return false;
is this branch actually getting hit? If so, where?

[Tom (Use chromium acct), 2016-09-23 20:34:57]

https://codereview.chromium.org/2353353005/diff/1/chrome/test/base/interactiv...
File chrome/test/base/interactive_test_utils_aura.cc (right):

https://codereview.chromium.org/2353353005/diff/1/chrome/test/base/interactiv...
chrome/test/base/interactive_test_utils_aura.cc:30: return false;
On 2016/09/23 16:27:56, sky wrote:
> is this branch actually getting hit? If so, where?

No

https://codereview.chromium.org/2353353005/diff/1/chrome/test/base/interactiv...
chrome/test/base/interactive_test_utils_aura.cc:32: return window->HasFocus();
HasFocus() is returning false.  This is because in
FocusController::FocusAndActivateWindow (focus_controller.cc:190), the window is
active, but not focused, so we early-return without getting focus.

[sky, 2016-09-26 01:48:17]

https://codereview.chromium.org/2353353005/diff/1/chrome/test/base/interactiv...
File chrome/test/base/interactive_test_utils_aura.cc (right):

https://codereview.chromium.org/2353353005/diff/1/chrome/test/base/interactiv...
chrome/test/base/interactive_test_utils_aura.cc:30: return false;
On 2016/09/23 20:34:57, Tom Anderson wrote:
> On 2016/09/23 16:27:56, sky wrote:
> > is this branch actually getting hit? If so, where?
> 
> No

Then can it be removed?

https://codereview.chromium.org/2353353005/diff/1/chrome/test/base/interactiv...
chrome/test/base/interactive_test_utils_aura.cc:32: return window->HasFocus();
On 2016/09/23 20:34:57, Tom Anderson wrote:
> HasFocus() is returning false.  This is because in
> FocusController::FocusAndActivateWindow (focus_controller.cc:190), the window
is
> active, but not focused, so we early-return without getting focus.

That is not necessarily problematic. What is the test case that fails?

[Tom (Use chromium acct), 2016-09-26 19:15:30]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[Tom (Use chromium acct), 2016-09-26 19:15:41]

https://codereview.chromium.org/2353353005/diff/1/chrome/test/base/interactiv...
File chrome/test/base/interactive_test_utils_aura.cc (right):

https://codereview.chromium.org/2353353005/diff/1/chrome/test/base/interactiv...
chrome/test/base/interactive_test_utils_aura.cc:30: return false;
On 2016/09/26 01:48:17, sky wrote:
> On 2016/09/23 20:34:57, Tom Anderson wrote:
> > On 2016/09/23 16:27:56, sky wrote:
> > > is this branch actually getting hit? If so, where?
> > 
> > No
> 
> Then can it be removed?

Done.

https://codereview.chromium.org/2353353005/diff/1/chrome/test/base/interactiv...
chrome/test/base/interactive_test_utils_aura.cc:32: return window->HasFocus();
On 2016/09/26 01:48:17, sky wrote:
> On 2016/09/23 20:34:57, Tom Anderson wrote:
> > HasFocus() is returning false.  This is because in
> > FocusController::FocusAndActivateWindow (focus_controller.cc:190), the
window
> is
> > active, but not focused, so we early-return without getting focus.
> 
> That is not necessarily problematic. What is the test case that fails?

Lots of them.  The example I was using to test was
WebViewPointerLockInteractiveTest.PointerLock_PointerLockLostWithFocus

I just changed this to return true like it was before :P

[commit-bot: I haz the power, 2016-09-26 19:15:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 19:57:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 19:57:17]

Dry run: This issue passed the CQ dry run.

[sky, 2016-09-26 20:24:41]

LGTM

[Tom (Use chromium acct), 2016-09-26 21:38:07]

The CQ bit was checked by thomasanderson@google.com

[commit-bot: I haz the power, 2016-09-26 21:38:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 21:45:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-26 21:47:54]

Description was changed from

==========
Aura: Focus() in ShowAndFocusNativeWindowAura

R=sky@chromium.org

BUG=649484
==========

to

==========
Aura: Focus() in ShowAndFocusNativeWindowAura

R=sky@chromium.org

BUG=649484

Committed: https://crrev.com/79cad3c950be7bff3b166b2c350770aaeca051fb
Cr-Commit-Position: refs/heads/master@{#421004}
==========

[commit-bot: I haz the power, 2016-09-26 21:47:55]

Patchset 2 (id:??) landed as
https://crrev.com/79cad3c950be7bff3b166b2c350770aaeca051fb
Cr-Commit-Position: refs/heads/master@{#421004}