Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2353353004:
[Sync] Misc ModelTypeWorker improvements. (Closed)
Description[Sync] Misc ModelTypeWorker improvements.
- Remove IsEncryptionRequired and just use cryptographer_ instead.
- Use ThreadChecker instead of NonThreadSafe.
- Tweak some comments.
- Simplify (without changing) the encryption handling logic in
ProcessGetUpdatesResponse.
- Make DecryptSpecifics not static so the cryptographer doesn't need to
be passed in.
BUG=648705
Committed: https://crrev.com/624769f8846b21df41108794722d21aa9f82e2fa
Cr-Commit-Position: refs/heads/master@{#420449}
Patch Set 1 #Patch Set 2 : Couple more comment tweaks. #
Total comments: 2
Patch Set 3 : Address comment. #
Messages
Total messages: 24 (17 generated)
The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
maxbogue@chromium.org changed reviewers: + pavely@chromium.org
Pavel, PTAL!
skym@chromium.org changed reviewers: + skym@chromium.org
lgtm https://codereview.chromium.org/2353353004/diff/20001/components/sync/engine_... File components/sync/engine_impl/model_type_worker.h (right): https://codereview.chromium.org/2353353004/diff/20001/components/sync/engine_... components/sync/engine_impl/model_type_worker.h:125: // parameter. Assumes cryptographer->CanDecrypt(specifics) returned true. cryptographer_ ?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
lgtm
The CQ bit was checked by maxbogue@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2353353004/diff/20001/components/sync/engine_... File components/sync/engine_impl/model_type_worker.h (right): https://codereview.chromium.org/2353353004/diff/20001/components/sync/engine_... components/sync/engine_impl/model_type_worker.h:125: // parameter. Assumes cryptographer->CanDecrypt(specifics) returned true. On 2016/09/22 17:37:54, skym wrote: > cryptographer_ ? Done.
The CQ bit was checked by maxbogue@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from skym@chromium.org, pavely@chromium.org Link to the patchset: https://codereview.chromium.org/2353353004/#ps40001 (title: "Address comment.")
The CQ bit was unchecked by maxbogue@chromium.org
The CQ bit was checked by maxbogue@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [Sync] Misc ModelTypeWorker improvements. - Remove IsEncryptionRequired and just use cryptographer_ instead. - Use ThreadChecker instead of NonThreadSafe. - Tweak some comments. - Simplify (without changing) the encryption handling logic in ProcessGetUpdatesResponse. - Make DecryptSpecifics not static so the cryptographer doesn't need to be passed in. BUG=648705 ========== to ========== [Sync] Misc ModelTypeWorker improvements. - Remove IsEncryptionRequired and just use cryptographer_ instead. - Use ThreadChecker instead of NonThreadSafe. - Tweak some comments. - Simplify (without changing) the encryption handling logic in ProcessGetUpdatesResponse. - Make DecryptSpecifics not static so the cryptographer doesn't need to be passed in. BUG=648705 Committed: https://crrev.com/624769f8846b21df41108794722d21aa9f82e2fa Cr-Commit-Position: refs/heads/master@{#420449} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/624769f8846b21df41108794722d21aa9f82e2fa Cr-Commit-Position: refs/heads/master@{#420449} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
