Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: net/http/http_server_properties_manager_unittest.cc

Issue 2353333005: Remove AlternateProtocol::NPN_SPDY_3_1. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_server_properties_impl_unittest.cc ('k') | net/http/http_stream_factory_impl_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_server_properties_manager_unittest.cc
diff --git a/net/http/http_server_properties_manager_unittest.cc b/net/http/http_server_properties_manager_unittest.cc
index 140be0718606e0425eec2f97885fcc10b227e41a..1f999a92b13f9cde54cf637b1b6a364f9f4809e9 100644
--- a/net/http/http_server_properties_manager_unittest.cc
+++ b/net/http/http_server_properties_manager_unittest.cc
@@ -284,7 +284,7 @@ TEST_P(HttpServerPropertiesManagerTest,
// Set up alternative_services for https://mail.google.com.
std::unique_ptr<base::DictionaryValue> alternative_service_dict2(
new base::DictionaryValue);
- alternative_service_dict2->SetString("protocol_str", "npn-spdy/3.1");
+ alternative_service_dict2->SetString("protocol_str", "h2");
alternative_service_dict2->SetInteger("port", 444);
base::ListValue* alternative_service_list1 = new base::ListValue;
alternative_service_list1->Append(std::move(alternative_service_dict2));
@@ -381,7 +381,7 @@ TEST_P(HttpServerPropertiesManagerTest,
AlternativeServiceMap::const_iterator map_it = map.begin();
EXPECT_EQ("mail.google.com", map_it->first.host());
ASSERT_EQ(1u, map_it->second.size());
- EXPECT_EQ(NPN_SPDY_3_1, map_it->second[0].alternative_service.protocol);
+ EXPECT_EQ(NPN_HTTP_2, map_it->second[0].alternative_service.protocol);
EXPECT_TRUE(map_it->second[0].alternative_service.host.empty());
EXPECT_EQ(444, map_it->second[0].alternative_service.port);
++map_it;
@@ -409,7 +409,7 @@ TEST_P(HttpServerPropertiesManagerTest,
++map_it;
EXPECT_EQ("mail.google.com", map_it->first.host());
ASSERT_EQ(1u, map_it->second.size());
- EXPECT_EQ(NPN_SPDY_3_1, map_it->second[0].alternative_service.protocol);
+ EXPECT_EQ(NPN_HTTP_2, map_it->second[0].alternative_service.protocol);
EXPECT_TRUE(map_it->second[0].alternative_service.host.empty());
EXPECT_EQ(444, map_it->second[0].alternative_service.port);
}
@@ -1082,7 +1082,7 @@ TEST_P(HttpServerPropertiesManagerTest, UpdateCacheWithPrefs) {
http_server_props_manager_->SetAlternativeServices(
server_www, alternative_service_info_vector);
- AlternativeService mail_alternative_service(NPN_SPDY_3_1, "foo.google.com",
+ AlternativeService mail_alternative_service(NPN_HTTP_2, "foo.google.com",
444);
base::Time expiration3 = base::Time::Max();
http_server_props_manager_->SetAlternativeService(
@@ -1121,7 +1121,7 @@ TEST_P(HttpServerPropertiesManagerTest, UpdateCacheWithPrefs) {
"\"port\":1234,\"protocol_str\":\"h2\"}]}},"
"{\"http://mail.google.com\":{\"alternative_service\":[{"
"\"expiration\":\"9223372036854775807\",\"host\":\"foo.google.com\","
- "\"port\":444,\"protocol_str\":\"npn-spdy/3.1\"}],"
+ "\"port\":444,\"protocol_str\":\"h2\"}],"
"\"network_stats\":{\"srtt\":42}}}"
"],"
"\"supports_quic\":{\"address\":\"127.0.0.1\",\"used_quic\":true},"
« no previous file with comments | « net/http/http_server_properties_impl_unittest.cc ('k') | net/http/http_stream_factory_impl_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698