Issue 23533057: Makes native_widget_types forward declare ui::Cursor.

Issue 23533057: Makes native_widget_types forward declare ui::Cursor. (Closed)

Created:
7 years, 3 months ago by sky

Modified:
7 years, 3 months ago

Reviewers:
jamesr, Ben Goodger (Google)

CC:
chromium-reviews, extensions-reviews_chromium.org, sadrul, ben+watch_chromium.org, tfarina, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Makes native_widget_types forward declare ui::Cursor. BUG=none TEST=none R=ben@chromium.org, jamesr@chromium.org TBR=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223459

Patch Set 2 : Fix linux_aura #

Total comments: 1

Patch Set 4 : git cl change #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -3 lines)			Patch
M	ash/wm/image_cursors.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/extensions/extension_view_views.cc	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/browser/web_contents/aura/image_window_delegate.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/aura/test/test_window_delegate.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/base/cursor/cursor_loader_win.cc	View		1 chunk	+6 lines, -1 line	0 comments	Download
M	ui/gfx/native_widget_types.h	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	ui/keyboard/keyboard_controller.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/message_center/views/notification_view.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/views/view.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/views/widget/desktop_aura/desktop_native_widget_aura.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/views/widget/native_widget_aura.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/views/widget/root_view.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/views/widget/widget.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	webkit/common/cursors/webcursor.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

lgtm https://codereview.chromium.org/23533057/diff/20001/chrome/browser/ui/views/extensions/extension_view_views.cc File chrome/browser/ui/views/extensions/extension_view_views.cc (right): https://codereview.chromium.org/23533057/diff/20001/chrome/browser/ui/views/extensions/extension_view_views.cc#newcode20 chrome/browser/ui/views/extensions/extension_view_views.cc:20: #endif newline after

7 years, 3 months ago (2013-09-16 19:57:19 UTC) #2

sky

James, I'm TBRing you as this is just an addition of an include.

7 years, 3 months ago (2013-09-16 20:02:14 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/23533057/29001

7 years, 3 months ago (2013-09-16 20:02:51 UTC) #4

Message was sent while issue was closed.

Change committed as 223459

Expand Messages | Collapse Messages