Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 23533053: ninja/mac: Try to fix 'IOError: [Errno 2] No such file or directory' error. (Closed)

Created:
7 years, 3 months ago by Nico
Modified:
7 years, 3 months ago
Reviewers:
scottmg
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

ninja/mac: Try to fix 'IOError: [Errno 2] No such file or directory' error. Happening on this Blink bot: http://chromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac%20Builder%20%28dbg%29 This probably broke when we changed the generator to write ninja files after their contents are known -- because of that the folder doesn't exist yet when the per-arch files are written. R=scottmg@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1726

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M pylib/gyp/generator/ninja.py View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
7 years, 3 months ago (2013-09-12 19:52:01 UTC) #1
scottmg
lgtm
7 years, 3 months ago (2013-09-12 19:56:15 UTC) #2
Nico
7 years, 3 months ago (2013-09-12 20:02:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r1726 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698