Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: cc/layers/layer_impl_unittest.cc

Issue 23533051: [android_webview] Use a fraction to calculate scroll offset. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: get rid of NaNs Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« cc/layers/layer_impl.cc ('K') | « cc/layers/layer_impl.cc ('k') | content/browser/android/in_process/synchronous_compositor_impl.h » ('j') | content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/layer_impl_unittest.cc
diff --git a/cc/layers/layer_impl_unittest.cc b/cc/layers/layer_impl_unittest.cc
index 1ab7a71b2ca93a2d39c3e66e1201fa7a88da65b2..a70c57fcb90c4cacad6cf59eaa7cf6809b83b1e6 100644
--- a/cc/layers/layer_impl_unittest.cc
+++ b/cc/layers/layer_impl_unittest.cc
@@ -391,6 +391,7 @@ TEST_F(LayerImplScrollTest, ScrollByWithNonZeroOffset) {
class ScrollDelegateIgnore : public LayerScrollOffsetDelegate {
public:
+ virtual void SetMaxScrollOffset(gfx::Vector2dF max_scroll_offset) OVERRIDE {}
virtual void SetTotalScrollOffset(gfx::Vector2dF new_value) OVERRIDE {}
virtual gfx::Vector2dF GetTotalScrollOffset() OVERRIDE {
return fixed_offset_;
@@ -441,6 +442,7 @@ TEST_F(LayerImplScrollTest, ScrollByWithIgnoringDelegate) {
class ScrollDelegateAccept : public LayerScrollOffsetDelegate {
public:
+ virtual void SetMaxScrollOffset(gfx::Vector2dF max_scroll_offset) OVERRIDE {}
virtual void SetTotalScrollOffset(gfx::Vector2dF new_value) OVERRIDE {
current_offset_ = new_value;
}
« cc/layers/layer_impl.cc ('K') | « cc/layers/layer_impl.cc ('k') | content/browser/android/in_process/synchronous_compositor_impl.h » ('j') | content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java » ('J')

Powered by Google App Engine
This is Rietveld 408576698