Check for non-final field in the face of const constructors.

tests/compiler/dart2js/type_checker_test.dart

Index: tests/compiler/dart2js/type_checker_test.dart
diff --git a/tests/compiler/dart2js/type_checker_test.dart b/tests/compiler/dart2js/type_checker_test.dart
index e543480a07e257a566731408dc1f5d767582218f..95c0e0d3791988b0cf959a8c9573c7a24cc0776d 100644
--- a/tests/compiler/dart2js/type_checker_test.dart
+++ b/tests/compiler/dart2js/type_checker_test.dart
@@ -150,8 +150,8 @@ testSwitch() {
   analyze("switch (1.0) { case 1.0: break; case 1.5: break; }",
       [], []);
   analyze("switch (null) { case 1.0: break; case 2: break; }",
-      [MessageKind.SWITCH_CASE_TYPES_NOT_EQUAL_CASE, 
-       MessageKind.SWITCH_CASE_TYPES_NOT_EQUAL_CASE], 
+      [MessageKind.SWITCH_CASE_TYPES_NOT_EQUAL_CASE,
+       MessageKind.SWITCH_CASE_TYPES_NOT_EQUAL_CASE],
       [MessageKind.SWITCH_CASE_TYPES_NOT_EQUAL]);
 }
 
@@ -1497,7 +1497,7 @@ analyzeTopLevel(String text, [expectedWarnings]) {
   if (expectedWarnings == null) expectedWarnings = [];
   if (expectedWarnings is !List) expectedWarnings = [expectedWarnings];
 
-  compiler.diagnosticHandler = createHandler(text);
+  compiler.diagnosticHandler = createHandler(compiler, text);
 
   LibraryElement library = mockLibrary(compiler, text);
 
@@ -1536,29 +1536,13 @@ analyzeTopLevel(String text, [expectedWarnings]) {
   compiler.diagnosticHandler = null;
 }
 
-api.DiagnosticHandler createHandler(String text) {
-  return (uri, int begin, int end, String message, kind) {
-    SourceFile sourceFile;
-    if (uri == null) {
-      sourceFile = new SourceFile('analysis', text);
-    } else {
-      sourceFile = compiler.sourceFiles[uri.toString()];
-    }
-    if (sourceFile != null) {
-      print(sourceFile.getLocationMessage(message, begin, end, true, (x) => x));
-    } else {
-      print(message);
-    }
-  };
-}
-
 analyze(String text, [expectedWarnings, expectedErrors]) {
   if (expectedWarnings == null) expectedWarnings = [];
   if (expectedWarnings is !List) expectedWarnings = [expectedWarnings];
   if (expectedErrors == null) expectedErrors = [];
   if (expectedErrors is !List) expectedErrors = [expectedErrors];
 
-  compiler.diagnosticHandler = createHandler(text);
+  compiler.diagnosticHandler = createHandler(compiler, text);
 
   Token tokens = scan(text);
   NodeListener listener = new NodeListener(compiler, null);