Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: tests/compiler/dart2js/message_kind_helper.dart

Issue 23533040: Check for non-final field in the face of const constructors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/co19/co19-dart2js.status ('k') | tests/compiler/dart2js/mock_compiler.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/message_kind_helper.dart
diff --git a/tests/compiler/dart2js/message_kind_helper.dart b/tests/compiler/dart2js/message_kind_helper.dart
index b4c554027bb7a3a1a5b008ce87f19d332cec04d3..b702d021e1d738ec8701e8dfaf0cc61f7b88bf5d 100644
--- a/tests/compiler/dart2js/message_kind_helper.dart
+++ b/tests/compiler/dart2js/message_kind_helper.dart
@@ -44,13 +44,18 @@ Future<Compiler> check(MessageKind kind, Compiler cachedCompiler) {
new RegExp(ESCAPE_REGEXP), (m) => '\\${m[0]}');
pattern = pattern.replaceAll(new RegExp(r'#\\\{[^}]*\\\}'), '.*');
+ // TODO(johnniwinther): Extend MessageKind to contain information on
+ // where info messages are expected.
+ bool messageFound = false;
for (String message in messages) {
- Expect.isTrue(new RegExp('^$pattern\$').hasMatch(message),
- '"$pattern" does not match "$message"');
+ if (new RegExp('^$pattern\$').hasMatch(message)) {
+ messageFound = true;
+ }
}
+ Expect.isTrue(messageFound, '"$pattern" does not match any in $messages');
return compiler;
});
}
- return cachedCompiler;
+ return new Future<Compiler>.sync(cachedCompiler);
}
« no previous file with comments | « tests/co19/co19-dart2js.status ('k') | tests/compiler/dart2js/mock_compiler.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698