sdk/lib/_internal/lib/foreign_helper.dart - Issue 23533040: Check for non-final field in the face of const constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/lib/foreign_helper.dart

Issue 23533040: Check for non-final field in the face of const constructors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/warnings.dart ('K') | « sdk/lib/_internal/compiler/implementation/warnings.dart ('k') | tests/co19/co19-dart2dart.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/lib/foreign_helper.dart

diff --git a/sdk/lib/_internal/lib/foreign_helper.dart b/sdk/lib/_internal/lib/foreign_helper.dart

index a45d9bfa000d9172dcf830894f16bb12d240feba..165a0a480659e1a7cad96497f7f449d4eeef15f5 100644

--- a/sdk/lib/_internal/lib/foreign_helper.dart

+++ b/sdk/lib/_internal/lib/foreign_helper.dart

@@ -266,6 +266,6 @@ void JS_EFFECT(Function code) { code(null); }

* $.JS_CONST_1 = typeof window != "undefined";

class JS_CONST {

- String code;

+ final String code;

const JS_CONST(this.code);

}