Make creation of CPDFSDK_Document clearer

fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "fpdfsdk/fpdfxfa/include/fpdfxfa_doc.h"
 
 #include "core/fpdfapi/fpdf_parser/include/cpdf_document.h"
 #include "fpdfsdk/fpdfxfa/include/fpdfxfa_app.h"
@@ skipping 173 matching lines @@
     return;
 
   if (CPDFXFA_Page* pPage = m_XFAPageList.GetAt(page_index))
     pPage->Release();
 }
 
 void CPDFXFA_Document::RemovePage(CPDFXFA_Page* page) {
   m_XFAPageList.SetAt(page->GetPageIndex(), nullptr);
 }
 
-CPDFSDK_Document* CPDFXFA_Document::GetSDKDocument(
-    CPDFSDK_Environment* pFormFillEnv) {
-  if (!m_pSDKDoc && pFormFillEnv)
-    m_pSDKDoc.reset(new CPDFSDK_Document(this, pFormFillEnv));
-  return m_pSDKDoc.get();
+void CPDFXFA_Document::SetSDKDoc(std::unique_ptr<CPDFSDK_Document> pSDKDoc) {

[dsinclair, 2016/09/22 14:50:10]

The one difference between this and the old code, in the old world if
FPDFDOC_InitFormFillEnvironment was called twice, we'd have the same
CPDFSDK_Document. In this world, we'll have a new one.

[Tom Sepez, 2016/09/22 17:02:23]

Acknowledged.

[Tom Sepez, 2016/09/22 17:04:42]

Actually, this scares me.  who own the CPDFSKD_Document?  The XFA document or th
CPDFSDK_Environment?

[dsinclair, 2016/09/22 17:32:12]

Depends. In XFA it's owned by CPDFXFA_Document. In non-XFA, it's owned by the
CPDFSDK_Environment.  I changed the Init code so that this shouldn't happen,
basically if the CPDFXFA_Document has been init'd already then we just return
the previously created Environment.

+  m_pSDKDoc.reset(pSDKDoc.release());
 }
 
 void CPDFXFA_Document::ClearChangeMark() {
   if (m_pSDKDoc)
     m_pSDKDoc->ClearChangeMark();
 }