[promises] Don't create resolving functions for PromiseCreate

[promises] Don't create resolving functions for PromiseCreate

Previously passing in the PromiseNopResolver function to the Promise
constructor would result in creating the resolving functions to be in
passed in to the executor, but the PromiseNopResolver does not use
these resolving functions resulting in wastefully creating these closures.

Instead we pass in the promiseRawSymbol to the promise constructor
so that these unnecessary resolving functions are not created.

BUG=v8:5046
Committed: https://crrev.com/1f89abcb9aca6d598198eb2743533b4775232a83
Cr-Commit-Position: refs/heads/master@{#39791}

[gsathya, 2016-09-21 21:31:12]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 21:31:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 21:50:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 21:50:58]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)

[gsathya, 2016-09-21 22:17:31]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 22:17:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 22:45:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 22:45:05]

Dry run: This issue passed the CQ dry run.

[gsathya, 2016-09-21 22:46:33]

gsathya@chromium.org changed reviewers:
+ adamk@chromium.org, littledan@chromium.org

[gsathya, 2016-09-21 22:46:43]

PTAL

[Dan Ehrenberg, 2016-09-21 22:48:53]

lgtm

It would be fun to see performance results about this patch.

[adamk, 2016-09-21 22:49:18]

Please add more to the CL description. As-is I really don't know what this patch
does (or why).

[neis, 2016-09-23 19:50:43]

neis@chromium.org changed reviewers:
+ neis@chromium.org

[neis, 2016-09-23 19:50:44]

lgtm

[gsathya, 2016-09-27 15:59:09]

Description was changed from

==========
[promises] Don't create resolving functions for PromiseCreate
==========

to

==========
[promises] Don't create resolving functions for PromiseCreate

Previously passing in the PromiseNopResolver function to the Promise 
constructor would result in creating the resolving functions to be in 
passed in to the executor, but the PromiseNopResolver does not use 
these resolving functions resulting in wastefully creating these closures.

Instead we pass in the promiseRawSymbol to the promise constructor 
so that these unnecessary resolving functions are not created.

BUG=v8:5046
==========

[gsathya, 2016-09-27 15:59:28]

On 2016/09/21 22:49:18, adamk wrote:
> Please add more to the CL description. As-is I really don't know what this
patch
> does (or why).

Updated CL description.

[adamk, 2016-09-27 18:10:10]

https://codereview.chromium.org/2353303003/diff/20001/src/js/promise.js
File src/js/promise.js (right):

https://codereview.chromium.org/2353303003/diff/20001/src/js/promise.js#newco...
src/js/promise.js:227: function PromiseNopResolver() {}
Can this now be deleted?

[gsathya, 2016-09-27 18:14:56]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 18:15:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gsathya, 2016-09-27 18:39:57]

On 2016/09/27 18:10:10, adamk wrote:
> https://codereview.chromium.org/2353303003/diff/20001/src/js/promise.js
> File src/js/promise.js (right):
> 
>
https://codereview.chromium.org/2353303003/diff/20001/src/js/promise.js#newco...
> src/js/promise.js:227: function PromiseNopResolver() {}
> Can this now be deleted?

Done.

[commit-bot: I haz the power, 2016-09-27 18:42:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 18:42:12]

Dry run: This issue passed the CQ dry run.

[adamk, 2016-09-27 18:43:28]

lgtm

[gsathya, 2016-09-27 18:43:42]

The CQ bit was checked by gsathya@chromium.org

[gsathya, 2016-09-27 18:43:43]

The patchset sent to the CQ was uploaded after l-g-t-m from neis@chromium.org,
littledan@chromium.org
Link to the patchset: https://codereview.chromium.org/2353303003/#ps40001
(title: "remove unnecessary function")

[commit-bot: I haz the power, 2016-09-27 18:43:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 18:46:09]

Description was changed from

==========
[promises] Don't create resolving functions for PromiseCreate

Previously passing in the PromiseNopResolver function to the Promise 
constructor would result in creating the resolving functions to be in 
passed in to the executor, but the PromiseNopResolver does not use 
these resolving functions resulting in wastefully creating these closures.

Instead we pass in the promiseRawSymbol to the promise constructor 
so that these unnecessary resolving functions are not created.

BUG=v8:5046
==========

to

==========
[promises] Don't create resolving functions for PromiseCreate

Previously passing in the PromiseNopResolver function to the Promise 
constructor would result in creating the resolving functions to be in 
passed in to the executor, but the PromiseNopResolver does not use 
these resolving functions resulting in wastefully creating these closures.

Instead we pass in the promiseRawSymbol to the promise constructor 
so that these unnecessary resolving functions are not created.

BUG=v8:5046
==========

[commit-bot: I haz the power, 2016-09-27 18:46:11]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-27 18:46:26]

Description was changed from

==========
[promises] Don't create resolving functions for PromiseCreate

Previously passing in the PromiseNopResolver function to the Promise 
constructor would result in creating the resolving functions to be in 
passed in to the executor, but the PromiseNopResolver does not use 
these resolving functions resulting in wastefully creating these closures.

Instead we pass in the promiseRawSymbol to the promise constructor 
so that these unnecessary resolving functions are not created.

BUG=v8:5046
==========

to

==========
[promises] Don't create resolving functions for PromiseCreate

Previously passing in the PromiseNopResolver function to the Promise
constructor would result in creating the resolving functions to be in
passed in to the executor, but the PromiseNopResolver does not use
these resolving functions resulting in wastefully creating these closures.

Instead we pass in the promiseRawSymbol to the promise constructor
so that these unnecessary resolving functions are not created.

BUG=v8:5046

Committed: https://crrev.com/1f89abcb9aca6d598198eb2743533b4775232a83
Cr-Commit-Position: refs/heads/master@{#39791}
==========

[commit-bot: I haz the power, 2016-09-27 18:46:27]

Patchset 3 (id:??) landed as
https://crrev.com/1f89abcb9aca6d598198eb2743533b4775232a83
Cr-Commit-Position: refs/heads/master@{#39791}