Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2353303002: [crankshaft] HCallWithDescriptor is now able to pass arguments on the stack. (Closed)

Created:
4 years, 3 months ago by Igor Sheludko
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] HCallWithDescriptor is now able to pass arguments on the stack. BUG=v8:5407 Committed: https://crrev.com/0acde6f974dbaccb8aa807d3623aea912ee7837e Cr-Commit-Position: refs/heads/master@{#39613}

Patch Set 1 #

Patch Set 2 : more changes #

Patch Set 3 : arm64 fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -84 lines) Patch
M src/code-stubs-hydrogen.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/crankshaft/arm/lithium-arm.cc View 2 chunks +15 lines, -7 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.cc View 1 2 2 chunks +25 lines, -7 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 2 1 chunk +10 lines, -1 line 0 comments Download
M src/crankshaft/hydrogen.cc View 1 5 chunks +19 lines, -17 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.cc View 2 chunks +16 lines, -7 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.cc View 2 chunks +15 lines, -7 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.cc View 2 chunks +15 lines, -7 lines 0 comments Download
M src/crankshaft/ppc/lithium-ppc.cc View 2 chunks +15 lines, -7 lines 0 comments Download
M src/crankshaft/s390/lithium-s390.cc View 2 chunks +15 lines, -7 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.cc View 2 chunks +15 lines, -7 lines 0 comments Download
M src/crankshaft/x87/lithium-x87.cc View 2 chunks +16 lines, -7 lines 0 comments Download

Messages

Total messages: 26 (18 generated)
Igor Sheludko
PTAL
4 years, 3 months ago (2016-09-21 12:00:23 UTC) #4
Benedikt Meurer
lgtm
4 years, 3 months ago (2016-09-21 12:11:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353303002/40001
4 years, 3 months ago (2016-09-21 12:17:41 UTC) #10
Igor Sheludko
It was a little bit trickier on arm64. PTAL arm64 fix.
4 years, 3 months ago (2016-09-21 17:21:10 UTC) #20
Benedikt Meurer
Still LGTM
4 years, 3 months ago (2016-09-22 06:51:54 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353303002/60001
4 years, 3 months ago (2016-09-22 06:52:23 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 3 months ago (2016-09-22 06:55:09 UTC) #24
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 06:55:48 UTC) #26
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0acde6f974dbaccb8aa807d3623aea912ee7837e
Cr-Commit-Position: refs/heads/master@{#39613}

Powered by Google App Engine
This is Rietveld 408576698