Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Side by Side Diff: chrome/browser/managed_mode/managed_mode_interstitial.h

Issue 23533014: Watch for filtering pref changes in ManagedModeInterstitial and unblock requests if they become… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: test Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_MANAGED_MODE_MANAGED_MODE_INTERSTITIAL_H_ 5 #ifndef CHROME_BROWSER_MANAGED_MODE_MANAGED_MODE_INTERSTITIAL_H_
6 #define CHROME_BROWSER_MANAGED_MODE_MANAGED_MODE_INTERSTITIAL_H_ 6 #define CHROME_BROWSER_MANAGED_MODE_MANAGED_MODE_INTERSTITIAL_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
11 #include "base/compiler_specific.h" 11 #include "base/compiler_specific.h"
12 #include "base/memory/weak_ptr.h" 12 #include "base/prefs/pref_change_registrar.h"
13 #include "content/public/browser/interstitial_page_delegate.h" 13 #include "content/public/browser/interstitial_page_delegate.h"
14 #include "url/gurl.h" 14 #include "url/gurl.h"
15 15
16 namespace content { 16 namespace content {
17 class InterstitialPage; 17 class InterstitialPage;
18 class WebContents; 18 class WebContents;
19 } 19 }
20 20
21 // Delegate for an interstitial page when a page is blocked in managed mode 21 // Delegate for an interstitial page when a page is blocked in managed mode
22 // because it is not on any whitelist. It lets an authorized user preview the 22 // because it is not on any whitelist. It lets an authorized user preview the
23 // blocked page, to decide later whether to manually allow it. 23 // blocked page, to decide later whether to manually allow it.
24 class ManagedModeInterstitial : public content::InterstitialPageDelegate { 24 class ManagedModeInterstitial : public content::InterstitialPageDelegate {
25 public: 25 public:
26 ManagedModeInterstitial(content::WebContents* web_contents, 26 ManagedModeInterstitial(content::WebContents* web_contents,
27 const GURL& url, 27 const GURL& url,
28 const base::Callback<void(bool)>& callback); 28 const base::Callback<void(bool)>& callback);
29 virtual ~ManagedModeInterstitial(); 29 virtual ~ManagedModeInterstitial();
30 30
31 private: 31 private:
32 // InterstitialPageDelegate implementation. 32 // InterstitialPageDelegate implementation.
33 virtual std::string GetHTMLContents() OVERRIDE; 33 virtual std::string GetHTMLContents() OVERRIDE;
34 virtual void CommandReceived(const std::string& command) OVERRIDE; 34 virtual void CommandReceived(const std::string& command) OVERRIDE;
35 virtual void OnProceed() OVERRIDE; 35 virtual void OnProceed() OVERRIDE;
36 virtual void OnDontProceed() OVERRIDE; 36 virtual void OnDontProceed() OVERRIDE;
37 37
38 // Returns whether the blocked URL is now allowed. Called initially before the
39 // interstitial is shown (to catch race conditions), or when the URL filtering
40 // prefs change.
41 bool ShouldProceed();
42
43 void OnFilteringPrefsChanged();
38 void DispatchContinueRequest(bool continue_request); 44 void DispatchContinueRequest(bool continue_request);
39 45
40 // Owns the interstitial, which owns us. 46 // Owns the interstitial, which owns us.
41 content::WebContents* web_contents_; 47 content::WebContents* web_contents_;
42 48
43 content::InterstitialPage* interstitial_page_; // Owns us. 49 content::InterstitialPage* interstitial_page_; // Owns us.
44 50
51 PrefChangeRegistrar pref_change_registrar_;
52
45 // The UI language. Used for formatting the URL for display. 53 // The UI language. Used for formatting the URL for display.
46 std::string languages_; 54 std::string languages_;
47 GURL url_; 55 GURL url_;
48 56
49 base::WeakPtrFactory<ManagedModeInterstitial> weak_ptr_factory_;
50 base::Callback<void(bool)> callback_; 57 base::Callback<void(bool)> callback_;
51 58
52 DISALLOW_COPY_AND_ASSIGN(ManagedModeInterstitial); 59 DISALLOW_COPY_AND_ASSIGN(ManagedModeInterstitial);
53 }; 60 };
54 61
55 #endif // CHROME_BROWSER_MANAGED_MODE_MANAGED_MODE_INTERSTITIAL_H_ 62 #endif // CHROME_BROWSER_MANAGED_MODE_MANAGED_MODE_INTERSTITIAL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698