Issue 23533013: Have RenderView's enclosingSeamlessRenderer() take a Document reference in argument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23533013: Have RenderView's enclosingSeamlessRenderer() take a Document reference in argument (Closed)

Created:
7 years, 3 months ago by do-not-use

Modified:
7 years, 3 months ago

Reviewers:
tkent, dglazkov

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Have RenderView's enclosingSeamlessRenderer() take a Document reference in argument Have RenderView's enclosingSeamlessRenderer() take a Document reference in argument instead of a pointer since the document can never be NULL. This avoids having to convert a reference into a pointer at the call sites and gets rid of a useless null-check. BUG=281400 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157099

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -6 lines)			Patch
	M	Source/core/rendering/RenderView.cpp	View		3 chunks	+4 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23533013/1

7 years, 3 months ago (2013-09-03 02:19:04 UTC) #3

Message was sent while issue was closed.

Change committed as 157099

Expand Messages | Collapse Messages