Implement fixpoint iteration for escape analysis.

Implement fixpoint iteration for escape analysis.

R=titzer@chromium.org

Committed: http://code.google.com/p/v8/source/detail?r=17235

[Michael Starzinger, 2013-08-27 18:10:31]

Note that this also fixes a bug in the materialization of heap numbers that this
implementation uncovered. I can move that into a separate CL if you think it
should be in separate changes.

[titzer, 2013-08-30 11:19:28]

https://codereview.chromium.org/23533003/diff/1/src/hydrogen-escape-analysis.h
File src/hydrogen-escape-analysis.h (right):

https://codereview.chromium.org/23533003/diff/1/src/hydrogen-escape-analysis....
src/hydrogen-escape-analysis.h:49: void Run() {
I would move this method into the .cc file and make the "more_work" variable
into the return value of the CollectCapturedValues() method--then you don't need
a field.

[Michael Starzinger, 2013-09-17 13:47:12]

PTAL. Addressed comments. Simplified. Rebased.

https://codereview.chromium.org/23533003/diff/1/src/hydrogen-escape-analysis.h
File src/hydrogen-escape-analysis.h (right):

https://codereview.chromium.org/23533003/diff/1/src/hydrogen-escape-analysis....
src/hydrogen-escape-analysis.h:49: void Run() {
On 2013/08/30 11:19:29, titzer wrote:
> I would move this method into the .cc file and make the "more_work" variable
> into the return value of the CollectCapturedValues() method--then you don't
need
> a field.

Done. After rebasing I can just check for "captured.is_empty()", much simpler
now with the latest version.

[titzer, 2013-09-27 08:27:12]

On 2013/09/17 13:47:12, Michael Starzinger wrote:
> PTAL. Addressed comments. Simplified. Rebased.
> 
> https://codereview.chromium.org/23533003/diff/1/src/hydrogen-escape-analysis.h
> File src/hydrogen-escape-analysis.h (right):
> 
>
https://codereview.chromium.org/23533003/diff/1/src/hydrogen-escape-analysis....
> src/hydrogen-escape-analysis.h:49: void Run() {
> On 2013/08/30 11:19:29, titzer wrote:
> > I would move this method into the .cc file and make the "more_work" variable
> > into the return value of the CollectCapturedValues() method--then you don't
> need
> > a field.
> 
> Done. After rebasing I can just check for "captured.is_empty()", much simpler
> now with the latest version.

Was this CL made obsolete by your recent changes?

[Michael Starzinger, 2013-09-27 08:39:00]

On 2013/09/27 08:27:12, titzer wrote:
> On 2013/09/17 13:47:12, Michael Starzinger wrote:
> > PTAL. Addressed comments. Simplified. Rebased.
> > 
> >
https://codereview.chromium.org/23533003/diff/1/src/hydrogen-escape-analysis.h
> > File src/hydrogen-escape-analysis.h (right):
> > 
> >
>
https://codereview.chromium.org/23533003/diff/1/src/hydrogen-escape-analysis....
> > src/hydrogen-escape-analysis.h:49: void Run() {
> > On 2013/08/30 11:19:29, titzer wrote:
> > > I would move this method into the .cc file and make the "more_work"
variable
> > > into the return value of the CollectCapturedValues() method--then you
don't
> > need
> > > a field.
> > 
> > Done. After rebasing I can just check for "captured.is_empty()", much
simpler
> > now with the latest version.
> 
> Was this CL made obsolete by your recent changes?

Nope, still needed, gives a nice performance boost.

[titzer, 2013-09-30 11:38:06]

lgtm

https://codereview.chromium.org/23533003/diff/6001/src/hydrogen-escape-analys...
File src/hydrogen-escape-analysis.h (right):

https://codereview.chromium.org/23533003/diff/6001/src/hydrogen-escape-analys...
src/hydrogen-escape-analysis.h:74: static const int kMaxFixpointIterationCount =
2;
How about a flag?

[Michael Starzinger, 2013-10-16 08:40:13]

Put the iteration count behind a flag. Landing.

https://codereview.chromium.org/23533003/diff/6001/src/hydrogen-escape-analys...
File src/hydrogen-escape-analysis.h (right):

https://codereview.chromium.org/23533003/diff/6001/src/hydrogen-escape-analys...
src/hydrogen-escape-analysis.h:74: static const int kMaxFixpointIterationCount =
2;
On 2013/09/30 11:38:06, titzer wrote:
> How about a flag?

Done.

[Michael Starzinger, 2013-10-16 09:17:04]

Committed patchset #3 manually as r17235 (presubmit successful).