[TimeZoneMonitor] Decouple //content/browser/time_zone_monitor* to //device/.

[TimeZoneMonitor] Decouple //content/browser/time_zone_monitor* to //device/.

BUG=612341
TEST=http://crbug.com/288697#c12: load the page, change the system time zone,
     and then click "recheck" to ensure that the renderer picks up the new
     time zone. Don't reload the page, which is likely to give you a new
     renderer process, use the "recheck" link on the page.

Committed: https://crrev.com/c6c6dca93baa98e7375f90589f1342d5b2ad5318
Cr-Commit-Position: refs/heads/master@{#420927}

[leonhsl(Using Gerrit), 2016-09-21 11:54:05]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 11:54:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 11:57:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 11:57:48]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[leonhsl(Using Gerrit), 2016-09-22 06:48:52]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 06:49:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 07:42:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 07:42:30]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[leonhsl(Using Gerrit), 2016-09-22 08:40:53]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 08:41:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[leonhsl(Using Gerrit), 2016-09-22 09:58:03]

leon.han@intel.com changed reviewers:
+ blundell@chromium.org

[leonhsl(Using Gerrit), 2016-09-22 09:58:04]

Hi, I can't wait anymore for the trybots results today, android trybots are
still running. Would you PTAL firstly? Thanks~

[commit-bot: I haz the power, 2016-09-22 10:10:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 10:10:55]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[blundell, 2016-09-22 15:32:27]

Thanks! It looks like the Android failures are real, but I didn't have time to
dig into them today. Can you investigate those failures and let me know if you
need another pair of eyes on them as well?

[leonhsl(Using Gerrit), 2016-09-23 02:58:41]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 02:59:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 03:51:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 03:51:56]

Dry run: This issue passed the CQ dry run.

[leonhsl(Using Gerrit), 2016-09-23 05:39:24]

OK android trybots are happy now at ps#4 ;-) Would you PTAL? Thanks.

[leonhsl(Using Gerrit), 2016-09-23 06:47:40]

On 2016/09/23 05:39:24, leonhsl wrote:
> OK android trybots are happy now at ps#4 ;-) Would you PTAL? Thanks.

Note: also tested locally on android phone, it's OK.

[blundell, 2016-09-23 11:06:55]

blundell@chromium.org changed reviewers:
+ jam@chromium.org

[blundell, 2016-09-23 11:06:56]

lgtm, thanks!

+jam for OWNERS (whole CL)

https://codereview.chromium.org/2353283002/diff/60001/device/time_zone_monito...
File device/time_zone_monitor/BUILD.gn (right):

https://codereview.chromium.org/2353283002/diff/60001/device/time_zone_monito...
device/time_zone_monitor/BUILD.gn:12: output_name = "device_time_zone_monitor"
nit: why is this necessary?

[leonhsl(Using Gerrit), 2016-09-23 15:18:08]

Thanks blundell@ a lot for kindly review.

https://codereview.chromium.org/2353283002/diff/60001/device/time_zone_monito...
File device/time_zone_monitor/BUILD.gn (right):

https://codereview.chromium.org/2353283002/diff/60001/device/time_zone_monito...
device/time_zone_monitor/BUILD.gn:12: output_name = "device_time_zone_monitor"
On 2016/09/23 11:06:56, blundell wrote:
> nit: why is this necessary?

The output library(.a or .so) could be named as 'device_time_zone_monitor',
which is more unique than just 'time_zone_monitor', although 'time_zone_monitor'
is already unique enough ;-)

[blundell, 2016-09-23 16:10:21]

https://codereview.chromium.org/2353283002/diff/60001/device/time_zone_monito...
File device/time_zone_monitor/BUILD.gn (right):

https://codereview.chromium.org/2353283002/diff/60001/device/time_zone_monito...
device/time_zone_monitor/BUILD.gn:12: output_name = "device_time_zone_monitor"
On 2016/09/23 15:18:08, leonhsl wrote:
> On 2016/09/23 11:06:56, blundell wrote:
> > nit: why is this necessary?
> 
> The output library(.a or .so) could be named as 'device_time_zone_monitor',
> which is more unique than just 'time_zone_monitor', although
'time_zone_monitor'
> is already unique enough ;-)

I think we should only use output_name when it's necessary, unless brettw@ or
dpranke@ have indicated otherwise.

[leonhsl(Using Gerrit), 2016-09-24 12:53:36]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-24 12:53:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[leonhsl(Using Gerrit), 2016-09-24 13:23:08]

Uploaded ps#5 to avoid setting output_name casually in gn. Thanks~

https://codereview.chromium.org/2353283002/diff/60001/device/time_zone_monito...
File device/time_zone_monitor/BUILD.gn (right):

https://codereview.chromium.org/2353283002/diff/60001/device/time_zone_monito...
device/time_zone_monitor/BUILD.gn:12: output_name = "device_time_zone_monitor"
On 2016/09/23 16:10:20, blundell wrote:
> On 2016/09/23 15:18:08, leonhsl wrote:
> > On 2016/09/23 11:06:56, blundell wrote:
> > > nit: why is this necessary?
> > 
> > The output library(.a or .so) could be named as 'device_time_zone_monitor',
> > which is more unique than just 'time_zone_monitor', although
> 'time_zone_monitor'
> > is already unique enough ;-)
> 
> I think we should only use output_name when it's necessary, unless brettw@ or
> dpranke@ have indicated otherwise.

Done.

[commit-bot: I haz the power, 2016-09-24 13:52:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-24 13:52:29]

Dry run: This issue passed the CQ dry run.

[leonhsl(Using Gerrit), 2016-09-26 14:22:05]

Ping jam@, Thanks.

[jam, 2016-09-26 15:14:36]

lgtm

[leonhsl(Using Gerrit), 2016-09-26 15:43:37]

The CQ bit was checked by leon.han@intel.com

[leonhsl(Using Gerrit), 2016-09-26 15:43:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
blundell@chromium.org
Link to the patchset: https://codereview.chromium.org/2353283002/#ps80001
(title: "Do not set output_name in gn")

[commit-bot: I haz the power, 2016-09-26 15:44:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 18:00:11]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-26 18:02:11]

Description was changed from

==========
[TimeZoneMonitor] Decouple //content/browser/time_zone_monitor* to //device/.

BUG=612341
TEST=http://crbug.com/288697#c12: load the page, change the system time zone,
     and then click "recheck" to ensure that the renderer picks up the new
     time zone. Don't reload the page, which is likely to give you a new
     renderer process, use the "recheck" link on the page.
==========

to

==========
[TimeZoneMonitor] Decouple //content/browser/time_zone_monitor* to //device/.

BUG=612341
TEST=http://crbug.com/288697#c12: load the page, change the system time zone,
     and then click "recheck" to ensure that the renderer picks up the new
     time zone. Don't reload the page, which is likely to give you a new
     renderer process, use the "recheck" link on the page.

Committed: https://crrev.com/c6c6dca93baa98e7375f90589f1342d5b2ad5318
Cr-Commit-Position: refs/heads/master@{#420927}
==========

[commit-bot: I haz the power, 2016-09-26 18:02:12]

Patchset 5 (id:??) landed as
https://crrev.com/c6c6dca93baa98e7375f90589f1342d5b2ad5318
Cr-Commit-Position: refs/heads/master@{#420927}