Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2353273002: Prune CreateVisiblePositionDeprecated from VisibleSelection.cpp (Closed)

Created:
4 years, 3 months ago by Xiaocheng
Modified:
4 years, 3 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune CreateVisiblePositionDeprecated from VisibleSelection.cpp BUG=647219 Committed: https://crrev.com/dbf5803bdb2f7077426fe5cbe353bd7adfe091fb Cr-Commit-Position: refs/heads/master@{#420051}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -20 lines) Patch
M third_party/WebKit/Source/core/editing/VisibleSelection.cpp View 10 chunks +29 lines, -20 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Xiaocheng
PTAL.
4 years, 3 months ago (2016-09-21 11:12:06 UTC) #4
yosin_UTC9
lgtm
4 years, 3 months ago (2016-09-21 14:35:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353273002/1
4 years, 3 months ago (2016-09-21 14:35:54 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 14:41:12 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 14:43:54 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dbf5803bdb2f7077426fe5cbe353bd7adfe091fb
Cr-Commit-Position: refs/heads/master@{#420051}

Powered by Google App Engine
This is Rietveld 408576698