Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Issue 2353243002: Revert "Document::haveImportsLoaded() should return true when ignoring pending sheets" (Closed)

Created:
4 years, 3 months ago by Xiaocheng
Modified:
4 years, 3 months ago
Reviewers:
esprehn, rune
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, kinuko+watch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Document::haveImportsLoaded() should return true when ignoring pending sheets" This is a manual revert of commit cd626f11b0ddb8fc655ac2fd808ca3930e3e29cf for causing crbug.com/648547. It also marks editing/selection/modify_move/move_backward_line_import_crash.html as crashing, because this layout test is a repro case of crbug.com/646323. Original issue's description: > Document::haveImportsLoaded() should return true when ignoring pending sheets > > BUG=646323 > TESTS=webkit_unit_tests DocumentLoadingRenderingTest.ShouldNotPerformRepeatedLayoutWithPendingImport DocumentLoadingRenderingTest.ShouldClearPlaceholderStyleWhenIgnoringPendingStylesheet > > Committed: https://crrev.com/cd626f11b0ddb8fc655ac2fd808ca3930e3e29cf > Cr-Commit-Position: refs/heads/master@{#419067} BUG=648547, 646323 TBR=esprehn@chromium.org,rune@chromium.org Committed: https://crrev.com/593d84c9016da731e62991eec28d998104b121da Cr-Commit-Position: refs/heads/master@{#420023}

Patch Set 1 #

Patch Set 2 : Mark the layout test TIMEOUT on Mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -78 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/DocumentLoadingRenderingTest.cpp View 1 chunk +0 lines, -76 lines 0 comments Download

Messages

Total messages: 16 (13 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353243002/20001
4 years, 3 months ago (2016-09-21 10:39:41 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-21 10:44:30 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 10:46:52 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/593d84c9016da731e62991eec28d998104b121da
Cr-Commit-Position: refs/heads/master@{#420023}

Powered by Google App Engine
This is Rietveld 408576698