Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 235323006: permalinks working (Closed)

Created:
6 years, 8 months ago by jcgregorio
Modified:
6 years, 8 months ago
Reviewers:
mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@sql
Visibility:
Public.

Description

Now with permalinks. Once we get a response from our XHR request update the URL to a permalink to that code. This CL comes after https://codereview.chromium.org/235373002/ BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14187

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 4

Patch Set 3 : fix sql formating #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -12 lines) Patch
M experimental/webtry/DESIGN.md View 1 chunk +2 lines, -0 lines 0 comments Download
M experimental/webtry/setup/continue_install View 1 chunk +1 line, -0 lines 0 comments Download
M experimental/webtry/templates/index.html View 2 chunks +2 lines, -8 lines 0 comments Download
M experimental/webtry/webtry.go View 1 2 10 chunks +53 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jcgregorio
6 years, 8 months ago (2014-04-11 20:37:06 UTC) #1
mtklein
https://codereview.chromium.org/235323006/diff/20001/experimental/webtry/DESIGN.md File experimental/webtry/DESIGN.md (right): https://codereview.chromium.org/235323006/diff/20001/experimental/webtry/DESIGN.md#newcode141 experimental/webtry/DESIGN.md:141: // If this gets changed also update the sqlite ...
6 years, 8 months ago (2014-04-11 21:45:06 UTC) #2
jcgregorio
https://codereview.chromium.org/235323006/diff/20001/experimental/webtry/DESIGN.md File experimental/webtry/DESIGN.md (right): https://codereview.chromium.org/235323006/diff/20001/experimental/webtry/DESIGN.md#newcode141 experimental/webtry/DESIGN.md:141: // If this gets changed also update the sqlite ...
6 years, 8 months ago (2014-04-12 02:37:07 UTC) #3
mtklein
On 2014/04/12 02:37:07, jcgregorio wrote: > https://codereview.chromium.org/235323006/diff/20001/experimental/webtry/DESIGN.md > File experimental/webtry/DESIGN.md (right): > > https://codereview.chromium.org/235323006/diff/20001/experimental/webtry/DESIGN.md#newcode141 > ...
6 years, 8 months ago (2014-04-12 13:27:15 UTC) #4
jcgregorio
The CQ bit was checked by jcgregorio@google.com
6 years, 8 months ago (2014-04-14 17:49:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/235323006/30001
6 years, 8 months ago (2014-04-14 17:49:27 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-14 18:53:29 UTC) #7
Message was sent while issue was closed.
Change committed as 14187

Powered by Google App Engine
This is Rietveld 408576698