Revert of Optimize repaint on FrameView resize

Revert of Optimize repaint on FrameView resize (https://codereview.chromium.org/213103003/)

Reason for revert:
Under-repaint if body has percentage positioned or bottom aligned background-image when changing height.

Will work on bug 358460 first.

Original issue's description:
> Optimize repaint on FrameView resize
> 
> Previously we always repaint the full FrameView on resize.
> 
> Don't mark full repaint if the resize is height-only and writing mode
> is horizontal. Any descendants needing repaint because of FrameView
> resize will still schedule their own repaints.
> 
> BUG=258219
> TEST=WebFrameTest.sizeChangeRepaint
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170427

TBR=ojan@chromium.org,dsinclair@chromium.org,esprehn@chromium.org,eseidel@chromium.org,jchaffraix@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=258219, 362407
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171362

[Xianzhu, 2014-04-11 18:23:19]

Created Revert of Optimize repaint on FrameView resize

[commit-bot: I haz the power, 2014-04-11 18:23:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/235323005/1

[commit-bot: I haz the power, 2014-04-11 18:23:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-11 18:23:35]

Failed to apply patch for Source/web/tests/WebFrameTest.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/web/tests/WebFrameTest.cpp
  Hunk #1 FAILED at 5283.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/web/tests/WebFrameTest.cpp.rej

Patch:       Source/web/tests/WebFrameTest.cpp
Index: Source/web/tests/WebFrameTest.cpp
diff --git a/Source/web/tests/WebFrameTest.cpp
b/Source/web/tests/WebFrameTest.cpp
index
35500ee751597a4275726a1067f078d2f543c83f..adc1d6edb24f96d7207e5d908cd57d165881a564
100644
--- a/Source/web/tests/WebFrameTest.cpp
+++ b/Source/web/tests/WebFrameTest.cpp
@@ -5283,79 +5283,6 @@
     EXPECT_EQ(1, client.callCount());
 }
 
-TEST_F(WebFrameTest, sizeChangeRepaint)
-{
-    const char* kTests[] = {
-        "repaint/size-change-repaint1.html",
-        "repaint/size-change-repaint2.html",
-        "repaint/size-change-repaint3.html",
-        "repaint/size-change-repaint4.html",
-        "repaint/size-change-repaint5.html",
-        "repaint/size-change-repaint6.html",
-        "repaint/size-change-repaint7.html",
-        "repaint/size-change-repaint8.html",
-        "repaint/size-change-repaint9.html",
-        "repaint/size-change-repaint10.html",
-    };
-
-    const WebCore::IntRect kExpectedRepaintOnHeightChange[] = {
-        WebCore::IntRect(0, 200, 200, 100),
-        WebCore::IntRect(0, 200, 200, 100),
-        WebCore::IntRect(0, 200, 200, 100),
-        WebCore::IntRect(0, 0, 200, 300),
-        WebCore::IntRect(0, 0, 200, 300),
-        WebCore::IntRect(0, 0, 200, 300),
-        WebCore::IntRect(0, 100, 200, 200),
-        WebCore::IntRect(0, 100, 200, 200),
-        WebCore::IntRect(0, 160, 200, 140),
-        WebCore::IntRect(0, 50, 200, 250),
-    };
-
-    const WebCore::IntRect kExpectedRepaintOnWidthChange[] = {
-        WebCore::IntRect(0, 0, 300, 300),
-        WebCore::IntRect(0, 0, 300, 300),
-        WebCore::IntRect(0, 0, 300, 300),
-        WebCore::IntRect(0, 0, 300, 300),
-        WebCore::IntRect(0, 0, 300, 300),
-        WebCore::IntRect(0, 0, 300, 300),
-        WebCore::IntRect(0, 0, 300, 300),
-        WebCore::IntRect(0, 0, 300, 300),
-        WebCore::IntRect(0, 0, 300, 300),
-        WebCore::IntRect(0, 0, 300, 300),
-    };
-
-    UseMockScrollbarSettings mockScrollbarSettings;
-
-    FrameTestHelpers::WebViewHelper webViewHelper;
-    WebViewImpl* webView = webViewHelper.initialize(true);
-
-    for (size_t i = 0; i < arraysize(kTests); ++i) {
-        SCOPED_TRACE(kTests[i]);
-        registerMockedHttpURLLoad(kTests[i]);
-        FrameTestHelpers::loadFrame(webView->mainFrame(), m_baseURL +
kTests[i]);
-       
Platform::current()->unitTestSupport()->serveAsynchronousMockedRequests();
-
-        webView->resize(WebSize(200, 200));
-        webView->layout();
-
-        // Change height.
-        WebCore::FrameView* frameView = webView->mainFrameImpl()->frameView();
-        frameView->setTracksRepaints(true);
-        webView->resize(WebSize(200, 300));
-        webView->layout();
-        WebCore::IntRect repaintRect =
WebCore::intersection(WebCore::IntRect(0, 0, 200, 300),
WebCore::unionRect(frameView->trackedRepaintRects()));
-        EXPECT_EQ_RECT(kExpectedRepaintOnHeightChange[i], repaintRect);
-
-        // Change width.
-        frameView->setTracksRepaints(true);
-        webView->resize(WebSize(300, 300));
-        webView->layout();
-        repaintRect = WebCore::intersection(WebCore::IntRect(0, 0, 300, 300),
WebCore::unionRect(frameView->trackedRepaintRects()));
-        EXPECT_EQ_RECT(kExpectedRepaintOnWidthChange[i], repaintRect);
-        frameView->setTracksRepaints(false);
-    }
-}
-
 TEST_F(WebFrameTest, fixedPositionInFixedViewport)
 {
     UseMockScrollbarSettings mockScrollbarSettings;

[Xianzhu, 2014-04-11 18:23:45]

The CQ bit was unchecked by wangxianzhu@chromium.org

[Xianzhu, 2014-04-11 18:24:09]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2014-04-11 18:24:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/235323005/1

[Xianzhu, 2014-04-11 18:24:15]

The CQ bit was unchecked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2014-04-11 18:24:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-11 18:24:29]

Failed to apply patch for Source/web/tests/WebFrameTest.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/web/tests/WebFrameTest.cpp
  Hunk #1 FAILED at 5283.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/web/tests/WebFrameTest.cpp.rej

Patch:       Source/web/tests/WebFrameTest.cpp
Index: Source/web/tests/WebFrameTest.cpp
diff --git a/Source/web/tests/WebFrameTest.cpp
b/Source/web/tests/WebFrameTest.cpp
index
35500ee751597a4275726a1067f078d2f543c83f..adc1d6edb24f96d7207e5d908cd57d165881a564
100644
--- a/Source/web/tests/WebFrameTest.cpp
+++ b/Source/web/tests/WebFrameTest.cpp
@@ -5283,79 +5283,6 @@
     EXPECT_EQ(1, client.callCount());
 }
 
-TEST_F(WebFrameTest, sizeChangeRepaint)
-{
-    const char* kTests[] = {
-        "repaint/size-change-repaint1.html",
-        "repaint/size-change-repaint2.html",
-        "repaint/size-change-repaint3.html",
-        "repaint/size-change-repaint4.html",
-        "repaint/size-change-repaint5.html",
-        "repaint/size-change-repaint6.html",
-        "repaint/size-change-repaint7.html",
-        "repaint/size-change-repaint8.html",
-        "repaint/size-change-repaint9.html",
-        "repaint/size-change-repaint10.html",
-    };
-
-    const WebCore::IntRect kExpectedRepaintOnHeightChange[] = {
-        WebCore::IntRect(0, 200, 200, 100),
-        WebCore::IntRect(0, 200, 200, 100),
-        WebCore::IntRect(0, 200, 200, 100),
-        WebCore::IntRect(0, 0, 200, 300),
-        WebCore::IntRect(0, 0, 200, 300),
-        WebCore::IntRect(0, 0, 200, 300),
-        WebCore::IntRect(0, 100, 200, 200),
-        WebCore::IntRect(0, 100, 200, 200),
-        WebCore::IntRect(0, 160, 200, 140),
-        WebCore::IntRect(0, 50, 200, 250),
-    };
-
-    const WebCore::IntRect kExpectedRepaintOnWidthChange[] = {
-        WebCore::IntRect(0, 0, 300, 300),
-        WebCore::IntRect(0, 0, 300, 300),
-        WebCore::IntRect(0, 0, 300, 300),
-        WebCore::IntRect(0, 0, 300, 300),
-        WebCore::IntRect(0, 0, 300, 300),
-        WebCore::IntRect(0, 0, 300, 300),
-        WebCore::IntRect(0, 0, 300, 300),
-        WebCore::IntRect(0, 0, 300, 300),
-        WebCore::IntRect(0, 0, 300, 300),
-        WebCore::IntRect(0, 0, 300, 300),
-    };
-
-    UseMockScrollbarSettings mockScrollbarSettings;
-
-    FrameTestHelpers::WebViewHelper webViewHelper;
-    WebViewImpl* webView = webViewHelper.initialize(true);
-
-    for (size_t i = 0; i < arraysize(kTests); ++i) {
-        SCOPED_TRACE(kTests[i]);
-        registerMockedHttpURLLoad(kTests[i]);
-        FrameTestHelpers::loadFrame(webView->mainFrame(), m_baseURL +
kTests[i]);
-       
Platform::current()->unitTestSupport()->serveAsynchronousMockedRequests();
-
-        webView->resize(WebSize(200, 200));
-        webView->layout();
-
-        // Change height.
-        WebCore::FrameView* frameView = webView->mainFrameImpl()->frameView();
-        frameView->setTracksRepaints(true);
-        webView->resize(WebSize(200, 300));
-        webView->layout();
-        WebCore::IntRect repaintRect =
WebCore::intersection(WebCore::IntRect(0, 0, 200, 300),
WebCore::unionRect(frameView->trackedRepaintRects()));
-        EXPECT_EQ_RECT(kExpectedRepaintOnHeightChange[i], repaintRect);
-
-        // Change width.
-        frameView->setTracksRepaints(true);
-        webView->resize(WebSize(300, 300));
-        webView->layout();
-        repaintRect = WebCore::intersection(WebCore::IntRect(0, 0, 300, 300),
WebCore::unionRect(frameView->trackedRepaintRects()));
-        EXPECT_EQ_RECT(kExpectedRepaintOnWidthChange[i], repaintRect);
-        frameView->setTracksRepaints(false);
-    }
-}
-
 TEST_F(WebFrameTest, fixedPositionInFixedViewport)
 {
     UseMockScrollbarSettings mockScrollbarSettings;

[Xianzhu, 2014-04-11 18:31:05]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2014-04-11 18:31:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/235323005/150001

[commit-bot: I haz the power, 2014-04-11 18:31:50]

Change committed as 171362