Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 23532076: GN: Add logging for the location of an invocation. (Closed)

Created:
7 years, 3 months ago by brettw
Modified:
7 years, 3 months ago
Reviewers:
scottmg
CC:
chromium-reviews, rginda+watch_chromium.org
Visibility:
Public.

Description

GN: Add logging for the location of an invocation. I was working on the Windows build and having problems finding why a file was loaded that shouldn't have been. This adds the source of the invocation to the verbose logging so you can find this information. I removed an assert which caused a debug assertion for random punctuation and isn't harmful (a real error will be reported). I moved the location-to-string conversion code into the location class so I can share it for my new logging command, and moved a bunch of other logging functions to the new .cc file. BUG=288991 R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223469

Patch Set 1 #

Patch Set 2 : iadd .cc file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -52 lines) Patch
M tools/gn/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/err.cc View 1 chunk +5 lines, -13 lines 0 comments Download
M tools/gn/gn.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/input_file_manager.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M tools/gn/location.h View 2 chunks +13 lines, -36 lines 0 comments Download
A tools/gn/location.cc View 1 1 chunk +73 lines, -0 lines 0 comments Download
M tools/gn/tokenizer.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
7 years, 3 months ago (2013-09-16 19:59:23 UTC) #1
scottmg
lgtm
7 years, 3 months ago (2013-09-16 20:13:05 UTC) #2
brettw
7 years, 3 months ago (2013-09-16 23:31:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r223469 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698