Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: scripts/slave/runtest.py

Issue 23532067: Pass '--verbose' and '--retries 0' flags to run_test_cases.py for ThreadSanitizer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/runtest.py
===================================================================
--- scripts/slave/runtest.py (revision 223030)
+++ scripts/slave/runtest.py (working copy)
@@ -1230,8 +1230,16 @@
(options.factory_properties.get('lsan_run_all_tests', False) or
args[0] not in lsan_blacklist)))
- if (options.factory_properties.get('asan', False)):
+ if options.factory_properties.get('asan', False):
options.extra_sharding_args += ' --verbose'
+ if options.factory_properties.get('tsan', False):
+ # Print ThreadSanitizer reports.
+ options.extra_sharding_args += ' --verbose'
+ if options.sharding_args is None:
M-A Ruel 2013/09/13 15:16:25 Worth using default='' at the options instead.
Alexander Potapenko 2013/09/13 15:23:08 Yeah, I was thinking about that option, but didn't
+ options.sharding_args = ''
+ # Data races may be flaky, but we don't want to restart the test if there's
+ # been a race report.
+ options.sharding_args += '--retries 0'
if (options.factory_properties.get('asan', False) or
options.factory_properties.get('tsan', False) or options.enable_lsan):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698