Pass '--verbose' and '--retries 0' flags to run_test_cases.py for ThreadSanitizer.

scripts/slave/runtest.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """A tool to run a chrome test executable, used by the buildbot slaves.
 
   When this is run, the current directory (cwd) should be the outer build
   directory (e.g., chrome-release/build/).
 
@@ skipping 1142 matching lines @@
                            help='Use default virtual X server on Linux.')
   option_parser.add_option('', '--auto-special-xvfb', action='store_const',
                            const='auto', dest='special_xvfb',
                            help='Guess as to virtual X server on Linux.')
   option_parser.add_option('', '--xvfb', action='store_true', dest='xvfb',
                            default=True,
                            help='Start virtual X server on Linux.')
   option_parser.add_option('', '--no-xvfb', action='store_false', dest='xvfb',
                            help='Do not start virtual X server on Linux.')
   option_parser.add_option('', '--sharding-args', dest='sharding_args',
-                           default=None,
+                           default='',
                            help='Options to pass to sharding_supervisor.')
   option_parser.add_option('-o', '--results-directory', default='',
                            help='output results directory for JSON file.')
   option_parser.add_option('', '--builder-name', default=None,
                            help='The name of the builder running this script.')
   option_parser.add_option('', '--build-number', default=None,
                            help=('The build number of the builder running'
                                  'this script.'))
   option_parser.add_option('', '--test-type', default='',
                            help='The test name that identifies the test, '
@@ skipping 49 matching lines @@
       'content_browsertests',
       'interactive_ui_tests',
       'net_unittests',
       'unit_tests',
   ]
   options.enable_lsan = (options.enable_lsan or
      (options.factory_properties.get('lsan', False) and
       (options.factory_properties.get('lsan_run_all_tests', False) or
        args[0] not in lsan_blacklist)))
 
-  if (options.factory_properties.get('asan', False)):
+  if options.factory_properties.get('asan', False):
     options.extra_sharding_args += ' --verbose'
+  if options.factory_properties.get('tsan', False):
+    # Print ThreadSanitizer reports.
+    options.extra_sharding_args += ' --verbose'
+    # Data races may be flaky, but we don't want to restart the test if there's
+    # been a race report.
+    options.sharding_args += '--retries 0'

[M-A Ruel, 2013/09/13 15:24:05]

' --retries 0'

[Alexander Potapenko, 2013/09/13 15:26:20]

Done.

 
   if (options.factory_properties.get('asan', False) or
       options.factory_properties.get('tsan', False) or options.enable_lsan):
     # Instruct GTK to use malloc while running ASan, TSan or LSan tests.
     os.environ['G_SLICE'] = 'always-malloc'
     os.environ['NSS_DISABLE_ARENA_FREE_LIST'] = '1'
     os.environ['NSS_DISABLE_UNLOAD'] = '1'
 
   # TODO(glider): remove the symbolizer path once
   # https://code.google.com/p/address-sanitizer/issues/detail?id=134 is fixed.
@@ skipping 83 matching lines @@
         '%d new files were left in %s: Fix the tests to clean up themselves.'
         ) % ((new_temp_files - temp_files), tempfile.gettempdir())
     # TODO(maruel): Make it an error soon. Not yet since I want to iron out all
     # the remaining cases before.
     #result = 1
   return result
 
 
 if '__main__' == __name__:
   sys.exit(main())