Add NetworkState::RequiresActivation.

Add NetworkState::RequiresActivation.

Added a utility function to NetworkState to query if a network
requires activation. All UI code should use this instead of comparing the
Cellular.ActivationState property themselves, as this utility function
handles the "unknown" case as well.

BUG=289470
R=stevenjb@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223472

[stevenjb, 2013-09-13 18:28:53]

https://codereview.chromium.org/23532065/diff/1/chromeos/network/network_acti...
File chromeos/network/network_activation_handler.cc (right):

https://codereview.chromium.org/23532065/diff/1/chromeos/network/network_acti...
chromeos/network/network_activation_handler.cc:46: network->activation_state()
!= flimflam::kActivationStateUnknown);
Since this takes a NetworkState* and only uses NetworkState properties, I would
rather just make this a member of NetworkState.

[armansito, 2013-09-16 21:19:20]

https://codereview.chromium.org/23532065/diff/1/chromeos/network/network_acti...
File chromeos/network/network_activation_handler.cc (right):

https://codereview.chromium.org/23532065/diff/1/chromeos/network/network_acti...
chromeos/network/network_activation_handler.cc:46: network->activation_state()
!= flimflam::kActivationStateUnknown);
On 2013/09/13 18:28:53, stevenjb wrote:
> Since this takes a NetworkState* and only uses NetworkState properties, I
would
> rather just make this a member of NetworkState.

Done.

[stevenjb, 2013-09-16 21:21:40]

lgtm

[armansito, 2013-09-16 23:36:23]

Committed patchset #4 manually as r223472 (presubmit successful).