runtime/bin/file.cc - Issue 23532048: Checks for valid CObject lengths in native API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/file.cc

Issue 23532048: Checks for valid CObject lengths in native API. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed comments. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/file.cc

diff --git a/runtime/bin/file.cc b/runtime/bin/file.cc

index bb6807102137f9875a58f93ab4fe1b81542b65b0..35ea5fc45e2a85d6883de302ef3f2789d421eda9 100644

--- a/runtime/bin/file.cc

+++ b/runtime/bin/file.cc

@@ -919,6 +919,7 @@ static CObject* FileReadRequest(const CObjectArray& request) {

if (!file->IsClosed()) {

int64_t length = CObjectInt32OrInt64ToInt64(request[2]);

Dart_CObject* io_buffer = CObject::NewIOBuffer(length);

+ ASSERT(io_buffer != NULL);

uint8_t* data = io_buffer->value.as_external_typed_data.data;

int64_t bytes_read = file->Read(data, length);

if (bytes_read >= 0) {

@@ -950,6 +951,7 @@ static CObject* FileReadIntoRequest(const CObjectArray& request) {