Issue 23532041: Binary Data for Extension Error Console UI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23532041: Binary Data for Extension Error Console UI (Closed)

Created:
7 years, 3 months ago by Devlin

Modified:
7 years, 3 months ago

Reviewers:
Yoyo Zhou, not at google - send to devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Binary Data for Extension Error Console UI Binary data separation from https://codereview.chromium.org/22938005/ in order to allow trybot and CQ run on that patch. BUG=21734 TBR=yoz@chromium.org, kalman@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221224

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -0 lines)		Patch
A +	chrome/browser/resources/extensions/extension_error_severity_fatal.png	View	Binary file	0 comments	Download
A	chrome/browser/resources/extensions/extension_error_severity_info.png	View	Binary file	0 comments	Download
A +	chrome/browser/resources/extensions/extension_error_severity_warning.png	View	Binary file	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/23532041/1

7 years, 3 months ago (2013-09-04 16:34:35 UTC) #1

commit-bot: I haz the power

Can't process patch for file chrome/browser/resources/extensions/extension_error_severity_info.png. Binary file support is temporarilly disabled due to a ...

7 years, 3 months ago (2013-09-04 16:34:44 UTC) #2

Devlin

7 years, 3 months ago (2013-09-04 17:31:11 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r221224 (presubmit successful).

Expand Messages | Collapse Messages