Postpone loading about:flags ui until the certificates have been loaded

chrome/browser/chromeos/login/parallel_authenticator.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/parallel_authenticator.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/logging.h"
@@ skipping 439 matching lines @@
   }
   // Now we can continue reading the private key.
   DeviceSettingsService::Get()->SetUsername(
       current_state_->user_context.username);
   DeviceSettingsService::Get()->GetOwnershipStatusAsync(
       base::Bind(&ParallelAuthenticator::OnOwnershipChecked, this));
   return false;
 }
 
 void ParallelAuthenticator::OnOwnershipChecked(
-    DeviceSettingsService::OwnershipStatus status,
-    bool is_owner) {
+    DeviceSettingsService::OwnershipStatus status) {
   // Now we can check if this user is the owner.
-  user_can_login_ = is_owner;
+  // TODO(tbarzic): This is broken. At this point, DeviceSettingsService will

[pastarmovj, 2013/09/05 12:48:18]

This used to be the case before though - the owner key was loaded as part of the
login procedure and could be verified here. This is what has regressed policy
recovery too. :-(

[tbarzic, 2013/09/05 17:59:17]

yep. I know..
that reminds me, I forgot to put a bug # in the comment..

+  // never have private key loaded.
+  user_can_login_ = DeviceSettingsService::Get()->HasPrivateOwnerKey();
   owner_is_verified_ = true;
   Resolve();
 }
 
 void ParallelAuthenticator::Resolve() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   bool request_pending = false;
   int mount_flags = cryptohome::MOUNT_FLAGS_NONE;
   ParallelAuthenticator::AuthState state = ResolveState();
   VLOG(1) << "Resolved state to: " << state;
@@ skipping 267 matching lines @@
   Resolve();
 }
 
 void ParallelAuthenticator::SetOwnerState(bool owner_check_finished,
                                           bool check_result) {
   owner_is_verified_ = owner_check_finished;
   user_can_login_ = check_result;
 }
 
 }  // namespace chromeos