Source/modules/encoding/TextDecoder.cpp - Issue 23532016: Handle odd data lengths in UTF-16 decoder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/encoding/TextDecoder.cpp

Issue 23532016: Handle odd data lengths in UTF-16 decoder (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebased Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/encoding/TextDecoder.cpp

diff --git a/Source/modules/encoding/TextDecoder.cpp b/Source/modules/encoding/TextDecoder.cpp

index 24a18cd59e94589b17f1e7bb7f4e21ae52e3b74d..c232fb91dcacd2b1d352cee8567b58931954943f 100644

--- a/Source/modules/encoding/TextDecoder.cpp

+++ b/Source/modules/encoding/TextDecoder.cpp

@@ -87,9 +87,6 @@ String TextDecoder::decode(ArrayBufferView* input, const Dictionary& options, Ex

bool flush = !stream;

- // FIXME: Not all TextCodec implementations handle |flush| - notably TextCodecUTF16

- // ignores it and never flushes!

bool sawError = false;

String s = m_codec->decode(start, length, flush, m_fatal, sawError);