Issue 23532011: Introduce toSVGTextElement(), and use it

Issue 23532011: Introduce toSVGTextElement(), and use it (Closed)

Created:
7 years, 3 months ago by gyuyoung-inactive

Modified:
7 years, 3 months ago

Reviewers:
tkent

CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, f(malita), jchaffraix+rendering, pdr, Stephen Chennney

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Introduce toSVGTextElement(), and use it As a step to clean-up static_cast<SVGXXX>, toSVGTextElement() is added to clean-up static_cast<SVGTextElement*>. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156955

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	Source/core/rendering/svg/RenderSVGText.cpp	View		1 chunk	+1 line, -2 lines	0 comments	Download
	M	Source/core/svg/SVGTextElement.h	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

tkent

https://codereview.chromium.org/23532011/diff/1/Source/core/svg/SVGTextElement.h File Source/core/svg/SVGTextElement.h (right): https://codereview.chromium.org/23532011/diff/1/Source/core/svg/SVGTextElement.h#newcode46 Source/core/svg/SVGTextElement.h:46: ASSERT_WITH_SECURITY_IMPLICATION(!node || node->hasTagName(SVGNames::polygonTag)); polygonTag ???

7 years, 3 months ago (2013-08-30 00:59:22 UTC) #2

gyuyoung-inactive

On 2013/08/30 00:59:22, tkent wrote: > https://codereview.chromium.org/23532011/diff/1/Source/core/svg/SVGTextElement.h > File Source/core/svg/SVGTextElement.h (right): > > https://codereview.chromium.org/23532011/diff/1/Source/core/svg/SVGTextElement.h#newcode46 > ...

7 years, 3 months ago (2013-08-30 01:12:05 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/23532011/7001

7 years, 3 months ago (2013-08-30 02:36:07 UTC) #5

Message was sent while issue was closed.

Change committed as 156955

Expand Messages | Collapse Messages