file_manager: Introduce FullTaskDescriptor

file_manager: Introduce FullTaskDescriptor

Generating JSON values inside Find* functions is uncool
and makes it hard to write tests.

BUG=269929
TEST=Files can be opened with Files.app as before
R=kinaba@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220513

[satorux1, 2013-08-29 08:17:33]

We'll soon be able to write unit tests...

https://codereview.chromium.org/23532010/diff/3001/chrome/browser/chromeos/ex...
File chrome/browser/chromeos/extensions/file_manager/file_tasks.cc (right):

https://codereview.chromium.org/23532010/diff/3001/chrome/browser/chromeos/ex...
chrome/browser/chromeos/extensions/file_manager/file_tasks.cc:406:
base::UTF16ToUTF8(iter->second.app_name),
should be gone once kinaba's patch landed.

[kinaba, 2013-08-29 09:33:35]

https://codereview.chromium.org/23532010/diff/3001/chrome/browser/chromeos/ex...
File chrome/browser/chromeos/extensions/file_manager/file_tasks.cc (right):

https://codereview.chromium.org/23532010/diff/3001/chrome/browser/chromeos/ex...
chrome/browser/chromeos/extensions/file_manager/file_tasks.cc:554: is_default =
true;
Add
*default_already_set = true;

https://codereview.chromium.org/23532010/diff/3001/chrome/browser/chromeos/ex...
File chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc
(right):

https://codereview.chromium.org/23532010/diff/3001/chrome/browser/chromeos/ex...
chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc:193: //
Conver the tasks into JSON format.
nit: Convert

[satorux1, 2013-08-30 02:01:34]

https://codereview.chromium.org/23532010/diff/3001/chrome/browser/chromeos/ex...
File chrome/browser/chromeos/extensions/file_manager/file_tasks.cc (right):

https://codereview.chromium.org/23532010/diff/3001/chrome/browser/chromeos/ex...
chrome/browser/chromeos/extensions/file_manager/file_tasks.cc:11: #include
"base/strings/utf_string_conversions.h"
gone!

https://codereview.chromium.org/23532010/diff/3001/chrome/browser/chromeos/ex...
chrome/browser/chromeos/extensions/file_manager/file_tasks.cc:406:
base::UTF16ToUTF8(iter->second.app_name),
On 2013/08/29 08:17:34, satorux1 wrote:
> should be gone once kinaba's patch landed.

removed

https://codereview.chromium.org/23532010/diff/3001/chrome/browser/chromeos/ex...
chrome/browser/chromeos/extensions/file_manager/file_tasks.cc:554: is_default =
true;
On 2013/08/29 09:33:35, kinaba wrote:
> Add
> *default_already_set = true;

good catch! I'm going to get rid of the clumsy defaul_already_set logic soon.

https://codereview.chromium.org/23532010/diff/3001/chrome/browser/chromeos/ex...
File chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc
(right):

https://codereview.chromium.org/23532010/diff/3001/chrome/browser/chromeos/ex...
chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc:193: //
Conver the tasks into JSON format.
On 2013/08/29 09:33:35, kinaba wrote:
> nit: Convert

Done.

[kinaba, 2013-08-30 02:19:38]

lgtm

https://codereview.chromium.org/23532010/diff/3001/chrome/browser/chromeos/ex...
File chrome/browser/chromeos/extensions/file_manager/file_tasks.cc (right):

https://codereview.chromium.org/23532010/diff/3001/chrome/browser/chromeos/ex...
chrome/browser/chromeos/extensions/file_manager/file_tasks.cc:554: is_default =
true;
On 2013/08/30 02:01:34, satorux1 wrote:
> On 2013/08/29 09:33:35, kinaba wrote:
> > Add
> > *default_already_set = true;
> 
> good catch! I'm going to get rid of the clumsy defaul_already_set logic soon.

Sounds good.

[satorux1, 2013-08-30 06:28:39]

Committed patchset #3 manually as r220513 (presubmit successful).