Issue 23532009: Get rid of script injection content observer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23532009: Get rid of script injection content observer. (Closed)

Created:
7 years, 3 months ago by dmazzoni

Modified:
4 years, 9 months ago

Reviewers:
David Trainor- moved to gerrit, klobag.chromium

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Get rid of script injection content observer. This holds a reference to ContentViewCore, preventing it from being garbage-collected and leading to crashes. Getting rid of it just means that Chrome decides which accessibility mode to enter once when a tab is created, rather than switching dynamically. It's not a major regression, and we can try to add it back another way later. BUG=157700

Patch Set 1 #

Patch Set 2 : Alternate fix #

Patch Set 3 : Add protocol version #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	content/public/android/java/src/org/chromium/content/browser/accessibility/KitKatBrowserAccessibilityManager.java	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dmazzoni

7 years, 3 months ago (2013-08-29 22:38:17 UTC) #3

(Note: I'm going to defer landing this until after
https://codereview.chromium.org/23750002/ because I think
that one will have a bigger impact faster.)

Expand Messages | Collapse Messages