Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 23532006: webkit can no longer depend on ppapi; shared_impl can now depend on ipc. (Closed)

Created:
7 years, 3 months ago by Matt Giuca
Modified:
7 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.og, raymes, yzshen1, chrome-apps-syd-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

webkit can no longer depend on ppapi; shared_impl can now depend on ipc. There is no longer any code in webkit/* that uses ppapi, so these dependencies can go. This means that ppapi/shared_impl code can now use ipc. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220800

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M ppapi/shared_impl/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
M webkit/common/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Matt Giuca
Hi, I'm wondering if I can remove some DEPS restrictions here? I want to use ...
7 years, 3 months ago (2013-08-28 05:28:46 UTC) #1
Matt Giuca
+darin for OWNERS.
7 years, 3 months ago (2013-08-28 05:29:41 UTC) #2
darin (slow to review)
LGTM!
7 years, 3 months ago (2013-08-29 01:34:15 UTC) #3
Matt Giuca
Thanks, Darin. Did you others (jam or brettw) have an opinion on this?
7 years, 3 months ago (2013-08-30 00:47:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/23532006/3001
7 years, 3 months ago (2013-09-02 00:56:26 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-02 05:25:46 UTC) #6
Message was sent while issue was closed.
Change committed as 220800

Powered by Google App Engine
This is Rietveld 408576698