Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1578)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2353193002: Update ddc pubspec.yaml (Closed)

Created:
4 years, 3 months ago by vsm
Modified:
4 years, 3 months ago
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update ddc pubspec.yaml Fixing build ... should we be doing something differently? E.g., not check in the lock file? TBR=jmesserly@google.com,rnystrom@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/e825d6d63efe012f0e01c21e38032879e67c0375

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/dev_compiler/pubspec.lock View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
vsm
Committed patchset #1 (id:1) manually as e825d6d63efe012f0e01c21e38032879e67c0375 (presubmit successful).
4 years, 3 months ago (2016-09-20 22:08:14 UTC) #2
Jennifer Messerly
yeah that seems reasonable.
4 years, 3 months ago (2016-09-20 22:30:25 UTC) #3
Jennifer Messerly
On 2016/09/20 22:30:25, John Messerly wrote: > yeah that seems reasonable. LGTM too
4 years, 3 months ago (2016-09-20 22:30:46 UTC) #4
Bob Nystrom
4 years, 3 months ago (2016-09-21 18:25:02 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698