Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2353133004: fix #27403, use AST summaries in DDC (Closed)

Created:
4 years, 3 months ago by Jennifer Messerly
Modified:
4 years, 3 months ago
Reviewers:
vsm, scheglov
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -91 lines) Patch
M pkg/dev_compiler/lib/js/amd/dart_sdk.js View 1 8 chunks +11 lines, -9 lines 0 comments Download
M pkg/dev_compiler/lib/js/common/dart_sdk.js View 1 8 chunks +11 lines, -9 lines 0 comments Download
M pkg/dev_compiler/lib/js/es6/dart_sdk.js View 1 8 chunks +11 lines, -9 lines 0 comments Download
M pkg/dev_compiler/lib/js/legacy/dart_sdk.js View 1 8 chunks +11 lines, -9 lines 0 comments Download
M pkg/dev_compiler/lib/src/analyzer/context.dart View 3 chunks +3 lines, -36 lines 0 comments Download
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 1 4 chunks +39 lines, -6 lines 0 comments Download
M pkg/dev_compiler/lib/src/compiler/compiler.dart View 1 6 chunks +38 lines, -11 lines 0 comments Download
M pkg/dev_compiler/test/codegen_expected/varargs.js View 1 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/dev_compiler/tool/sdk_expected_errors.txt View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Jennifer Messerly
This does not completely fix DDC's build issues but it gets past the serializeLibraryElement.
4 years, 3 months ago (2016-09-21 00:34:41 UTC) #4
scheglov
LGTM
4 years, 3 months ago (2016-09-21 00:39:25 UTC) #5
Jennifer Messerly
4 years, 3 months ago (2016-09-21 00:55:18 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
aa8565182054ba218c1b2f6c08213bc3d9c7cd70 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698