Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2353133003: Removing dcheck in SetUploadConsentImpl. (Closed)

Created:
4 years, 3 months ago by jwd
Modified:
4 years, 3 months ago
Reviewers:
scottmg
CC:
chromium-reviews, jam, darin-cc_chromium.org, sadrul, kalyank, gab
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing dcheck in SetUploadConsentImpl. This DCHECK is very easy to trigger by developers, googlers specifically, without actually violating the intent of the DCHECK. BUG=648594 Committed: https://crrev.com/6bbba65a7074b6cdbe1dada8d51d0ba90ff944b6 Cr-Commit-Position: refs/heads/master@{#419882}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M components/crash/content/app/crashpad.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
jwd
4 years, 3 months ago (2016-09-20 21:51:19 UTC) #2
scottmg
If you're confident in the bug's analysis, lgtm.
4 years, 3 months ago (2016-09-20 22:09:05 UTC) #4
jwd
On 2016/09/20 22:09:05, scottmg wrote: > If you're confident in the bug's analysis, lgtm. For ...
4 years, 3 months ago (2016-09-20 22:18:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353133003/1
4 years, 3 months ago (2016-09-20 22:19:22 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 22:57:34 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 23:00:52 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6bbba65a7074b6cdbe1dada8d51d0ba90ff944b6
Cr-Commit-Position: refs/heads/master@{#419882}

Powered by Google App Engine
This is Rietveld 408576698