Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2353133002: Roll Dartium browser deps (Closed)

Created:
4 years, 3 months ago by Bill Hesse
Modified:
4 years, 3 months ago
Reviewers:
terry, Alan Knight
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Roll Dartium browser deps This removes the package_build step, which has been removed from dart. There is no longer a package root built, but a checked-in package spec. BUG= R=alanknight@google.com Committed: https://github.com/dart-lang/sdk/commit/d07d1148d2eabedbd55200df2e5b2fe5e04a21bf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/deps/dartium.deps/DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Bill Hesse
4 years, 3 months ago (2016-09-20 19:24:10 UTC) #2
Alan Knight
lgtm
4 years, 3 months ago (2016-09-20 19:45:59 UTC) #4
Bill Hesse
4 years, 3 months ago (2016-09-20 19:54:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d07d1148d2eabedbd55200df2e5b2fe5e04a21bf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698