Issue 2353123002: Print the QuicReceivedPacketManager's ack frame instead of the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2353123002: Print the QuicReceivedPacketManager's ack frame instead of the (Closed)

Created:
4 years, 3 months ago by Jana

Modified:
4 years, 3 months ago

Reviewers:
ianswett, Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Print the QuicReceivedPacketManager's ack frame instead of the QuicPacketGenerator's ack frame to print connection debug info and remove QuicPacketGenerator's ack frame. Small functional change to print useful data. The ack frame being printed previously was never used, so would always be in the default initialized state. Merge internal change: 133400163 R=ianswett@chromium.org, rch@chromium.org BUG=

Patch Set 1 #

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	net/quic/core/quic_connection.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	net/quic/core/quic_packet_generator.h	View		2 chunks	+0 lines, -3 lines	0 comments	Download

Depends on Patchset:

Issue 2356873002 Patch 1

Dependent Patchsets:

Issue 2351303003 Patch 1

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages