src/x64/macro-assembler-x64.cc - Issue 23531084: Avoid using double temp register explicitly in lithium codegen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/macro-assembler-x64.cc

Issue 23531084: Avoid using double temp register explicitly in lithium codegen (Closed) Base URL: git://github.com/v8/v8.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/macro-assembler-x64.cc

diff --git a/src/x64/macro-assembler-x64.cc b/src/x64/macro-assembler-x64.cc

index 96fa4fc49630424093eaa29874c118e95c34a115..49065f09f5e010088d5ac1ba789b6ec74c38c149 100644

--- a/src/x64/macro-assembler-x64.cc

+++ b/src/x64/macro-assembler-x64.cc

@@ -3728,7 +3728,7 @@ void MacroAssembler::EnterExitFrameEpilogue(int arg_stack_space,

#endif

// Optionally save all XMM registers.

if (save_doubles) {

- int space = XMMRegister::kMaxNumRegisters * kDoubleSize +

+ int space = XMMRegister::kMaxNumAllocatableRegisters * kDoubleSize +

mvstanton 2013/09/25 07:00:30 Could you do the same thing on ia32, using Registe

arg_stack_space * kPointerSize;

subq(rsp, Immediate(space));

int offset = -2 * kPointerSize;

« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | no next file » | no next file with comments »