Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 23531070: Add expectations/gm/ignored-tests.txt to temporarily ignore failures (Closed)

Created:
7 years, 3 months ago by epoger
Modified:
7 years, 3 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add expectations/gm/ignored-tests.txt to temporarily ignore failures BUG=skia:1600 TBR=bsalomon (SkipBuildbotRuns) Committed: https://code.google.com/p/skia/source/detail?r=11390

Patch Set 1 #

Patch Set 2 : linewrap #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
A expectations/gm/ignored-tests.txt View 1 1 chunk +22 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
epoger
https://codereview.chromium.org/23531070/diff/3001/expectations/gm/ignored-tests.txt File expectations/gm/ignored-tests.txt (right): https://codereview.chromium.org/23531070/diff/3001/expectations/gm/ignored-tests.txt#newcode1 expectations/gm/ignored-tests.txt:1: # Failures of any GM tests listed in this ...
7 years, 3 months ago (2013-09-19 15:02:51 UTC) #1
epoger
https://codereview.chromium.org/23531070/diff/3001/expectations/gm/ignored-tests.txt File expectations/gm/ignored-tests.txt (right): https://codereview.chromium.org/23531070/diff/3001/expectations/gm/ignored-tests.txt#newcode1 expectations/gm/ignored-tests.txt:1: # Failures of any GM tests listed in this ...
7 years, 3 months ago (2013-09-19 16:13:44 UTC) #2
epoger
Committed patchset #2 manually as r11390 (presubmit successful).
7 years, 3 months ago (2013-09-19 17:41:48 UTC) #3
epoger
Apologies for the TBR commit. But I wanted to get it in before I leave ...
7 years, 3 months ago (2013-09-19 17:43:13 UTC) #4
bsalomon
7 years, 3 months ago (2013-09-19 18:05:37 UTC) #5
On 2013/09/19 17:43:13, epoger wrote:
> Apologies for the TBR commit.  But I wanted to get it in before I leave for
the
> weekend, in case someone finds it helpful.  And the file is almost exactly as
> described in https://code.google.com/p/skia/issues/detail?id=1600#c4.

No prob, I was out of the office. LGTM.

Powered by Google App Engine
This is Rietveld 408576698