Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 23531058: Missing *explicit* keyword in constructors (Closed)

Created:
7 years, 3 months ago by gyuyoung-inactive
Modified:
7 years, 3 months ago
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, f(malita), jchaffraix+rendering, pdr, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Missing *explicit* keyword in constructors Constructor which has one parameter needs to have explicit keyword in order to avoid implicit type conversion. BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157807

Patch Set 1 #

Messages

Total messages: 5 (0 generated)
gyuyoung-inactive
Add kentaro to reviewer.
7 years, 3 months ago (2013-09-14 23:38:11 UTC) #1
leviw_travelin_and_unemployed
lgtm
7 years, 3 months ago (2013-09-14 23:59:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/23531058/1
7 years, 3 months ago (2013-09-14 23:59:57 UTC) #3
commit-bot: I haz the power
Change committed as 157807
7 years, 3 months ago (2013-09-15 01:42:18 UTC) #4
haraken
7 years, 3 months ago (2013-09-15 03:06:44 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698