Don't switch browser locale on secondary user login

Don't switch browser locale on secondary user login

BUG=291114
TEST=manual
R=alemate@chromium.org, nkostylev@chromium.org, skuhne@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223403

[Mr4D (OOO till 08-26), 2013-09-13 23:41:36]

Please have a quick look at my two comments. Beside that: lgtm.

https://codereview.chromium.org/23531054/diff/3001/chrome/browser/chromeos/lo...
File chrome/browser/chromeos/login/login_utils.cc (right):

https://codereview.chromium.org/23531054/diff/3001/chrome/browser/chromeos/lo...
chrome/browser/chromeos/login/login_utils.cc:382: if
(UserManager::Get()->GetLoggedInUsers().size() == 1)
Don't know how this plays into it, but while debugging I have seen that the
login screen is also trying to set the user input locale
(signin_screen_handler.cc(1044)). I guess you should check that out quickly as
well).

Oh and: I am not sure that you can assume that the UserManager is already there.
You might want to check if you have to look at UserManager::IsInitialized().

[Dmitry Polukhin, 2013-09-14 00:28:16]

+ alemate who wrote SetUserInputMethod
+ nkostylev@ for OWNER review in chrome/browser/ui/webui/chromeos/login

https://codereview.chromium.org/23531054/diff/3001/chrome/browser/chromeos/lo...
File chrome/browser/chromeos/login/login_utils.cc (right):

https://codereview.chromium.org/23531054/diff/3001/chrome/browser/chromeos/lo...
chrome/browser/chromeos/login/login_utils.cc:382: if
(UserManager::Get()->GetLoggedInUsers().size() == 1)
On 2013/09/13 23:41:36, Mr4D wrote:
> Don't know how this plays into it, but while debugging I have seen that the
> login screen is also trying to set the user input locale
> (signin_screen_handler.cc(1044)). I guess you should check that out quickly as
> well).

Good catch! It is place where we can switch input methods (not locale). Fixed.

> Oh and: I am not sure that you can assume that the UserManager is already
there.
> You might want to check if you have to look at UserManager::IsInitialized().

It must be initialized already because UserManaged initiates profile creation.
But after crash not all user could be loaded, in this case we do want to apply
first user settings (it should be first logged in user) and skip other user
settings.

[Alexander Alekseev, 2013-09-14 14:46:44]

https://codereview.chromium.org/23531054/diff/11001/chrome/browser/chromeos/l...
File chrome/browser/chromeos/login/login_utils.cc (right):

https://codereview.chromium.org/23531054/diff/11001/chrome/browser/chromeos/l...
chrome/browser/chromeos/login/login_utils.cc:382: if
(UserManager::Get()->GetLoggedInUsers().size() == 1)
lgtm , though after https://codereview.chromium.org/23095006/ this check won't
be needed.

[Nikita (slow), 2013-09-16 16:28:16]

lgtm

https://codereview.chromium.org/23531054/diff/11001/chrome/browser/ui/webui/c...
File chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc (right):

https://codereview.chromium.org/23531054/diff/11001/chrome/browser/ui/webui/c...
chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc:1036: if
(user_manager->IsUserLoggedIn()) {
Ideally sign in UI should behave the same whether this is first user sign in or
additional user sign in.
Please put a TODO with a new bug assigned to Alexander to remove this check.

[Dmitry Polukhin, 2013-09-16 18:30:00]

https://codereview.chromium.org/23531054/diff/11001/chrome/browser/ui/webui/c...
File chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc (right):

https://codereview.chromium.org/23531054/diff/11001/chrome/browser/ui/webui/c...
chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc:1036: if
(user_manager->IsUserLoggedIn()) {
On 2013/09/16 16:28:17, Nikita Kostylev wrote:
> Ideally sign in UI should behave the same whether this is first user sign in
or
> additional user sign in.
> Please put a TODO with a new bug assigned to Alexander to remove this check.

Done.

[commit-bot: I haz the power, 2013-09-16 18:37:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dpolukhin@chromium.org/23531054/19001

[Dmitry Polukhin, 2013-09-16 20:38:44]

Committed patchset #4 manually as r223403 (presubmit successful).