Issue 23531047: I don't know what you've been told, rebaselining images never gets old

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23531047: I don't know what you've been told, rebaselining images never gets old (Closed)

Created:
7 years, 3 months ago by bsalomon

Modified:
7 years, 3 months ago

Reviewers:
epoger

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

I don't know what you've been told, rebaselining images never gets old R=epoger@google.com Committed: https://code.google.com/p/skia/source/detail?r=11255

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -14 lines)			Patch
M	expectations/gm/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/expected-results.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	expectations/gm/Test-Android-NexusS-SGX540-Arm7-Debug/expected-results.json	View	9 chunks	+9 lines, -9 lines	0 comments	Download
M	expectations/gm/Test-Android-NexusS-SGX540-Arm7-Release/expected-results.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	expectations/gm/Test-ChromeOS-Alex-GMA3150-x86-Debug/expected-results.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	expectations/gm/Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-ASAN/expected-results.json	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

epoger

7 years, 3 months ago (2013-09-13 17:47:55 UTC) #2

Message was sent while issue was closed.

LGTM

Thanks for taking care of these, Brian.  It will get better.

In the meanwhile, we can enjoy the "track this package" notifications gmail puts
in the sidebar for these emails, based on certain image checksums.

Expand Messages | Collapse Messages