Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 23531034: [NaCl SDK] Don't exit from nacl_io_test before posting message to JS. (Closed)

Created:
7 years, 3 months ago by binji
Modified:
7 years, 3 months ago
Reviewers:
Sam Clegg
CC:
chromium-reviews, Sam Clegg
Visibility:
Public.

Description

[NaCl SDK] Don't exit from nacl_io_test before posting message to JS. In the nacl_io_test there's a race condition between the NaCl module exiting and a posted message from the module being handled by JavaScript. To fix it, when running in the browser, we wait indefinitely and assume the JavaScript will kill the module when it is ready. (This fixes a flake that can be seen in http://build.chromium.org/p/client.nacl.sdk/builders/mac-sdk-multi/builds/5838/steps/Run%20Tests/logs/stdio BUG=none R=sbc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222065

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M native_client_sdk/src/examples/common.js View 2 chunks +9 lines, -0 lines 0 comments Download
M native_client_sdk/src/tests/nacl_io_test/example.js View 1 chunk +9 lines, -0 lines 0 comments Download
M native_client_sdk/src/tests/nacl_io_test/main.cc View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
binji
7 years, 3 months ago (2013-09-04 22:23:32 UTC) #1
Sam Clegg
lgtm, although we should probably have a preferred way for ppapi_simple apps to exit cleanly ...
7 years, 3 months ago (2013-09-04 22:31:09 UTC) #2
binji
OK, I'll land as-is. We should revisit how to handle this in ppapi_simple later.
7 years, 3 months ago (2013-09-06 20:41:39 UTC) #3
binji
7 years, 3 months ago (2013-09-09 18:50:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r222065 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698