Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: native_client_sdk/src/doc/PRESUBMIT.py

Issue 23531031: Minor cleanups for SDK devsite docs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
binji 2013/09/05 00:52:51 2013
2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file.
4
5 import subprocess
6
7 def _CheckSphinxBuild(input_api, output_api):
binji 2013/09/05 00:52:51 I assume this is only run if a file in the docs di
8 """Check that the docs are buildable without any warnings.
9
10 This check runs sphinx-build with -W so that warning are errors.
11 """
12
13 try:
14 subprocess.check_output(['make', 'SPHINXOPTS=-Wa'])
15 except subprocess.CalledProcessError as e:
16 return [output_api.PresubmitPromptError('sphinx_build failed:\n' +
17 e.output)]
18
19 return []
20
21
22 def CommonChecks(input_api, output_api):
23 output = []
24 output.extend(_CheckSphinxBuild(input_api, output_api))
25 return output
26
27
28 def CheckChangeOnUpload(input_api, output_api):
29 return CommonChecks(input_api, output_api)
30
31
32 def CheckChangeOnCommit(input_api, output_api):
33 return CommonChecks(input_api, output_api)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698